From bdd5f36121701c79522ffd617a4ae64f172285d8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julian=20Offenh=C3=A4user?= <offenhaeuser@protonmail.com>
Date: Fri, 24 Mar 2023 22:28:57 +0100
Subject: [PATCH] LibPDF: Load replacements for TrueTypeFonts without an
 embedded font

This previously only happened for Type 1 fonts.
---
 Userland/Libraries/LibPDF/Fonts/TrueTypeFont.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Userland/Libraries/LibPDF/Fonts/TrueTypeFont.cpp b/Userland/Libraries/LibPDF/Fonts/TrueTypeFont.cpp
index a35680bd51..48772a58aa 100644
--- a/Userland/Libraries/LibPDF/Fonts/TrueTypeFont.cpp
+++ b/Userland/Libraries/LibPDF/Fonts/TrueTypeFont.cpp
@@ -17,6 +17,7 @@ PDFErrorOr<void> TrueTypeFont::initialize(Document* document, NonnullRefPtr<Dict
 {
     TRY(SimpleFont::initialize(document, dict, font_size));
 
+    // If there's an embedded font program we use that; otherwise we try to find a replacement font
     if (dict->contains(CommonNames::FontDescriptor)) {
         auto descriptor = MUST(dict->get_dict(document, CommonNames::FontDescriptor));
         if (descriptor->contains(CommonNames::FontFile2)) {
@@ -26,7 +27,11 @@ PDFErrorOr<void> TrueTypeFont::initialize(Document* document, NonnullRefPtr<Dict
             m_font = adopt_ref(*new Gfx::ScaledFont(*ttf_font, point_size, point_size));
         }
     }
+    if (!m_font) {
+        m_font = TRY(replacement_for(base_font_name().to_lowercase(), font_size));
+    }
 
+    VERIFY(m_font);
     return {};
 }