RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:07:44 +00:00
Code Issues Activity Actions

Spreadsheet: Don't release the file buffer when importing CSV files

Browse source 
CSVImportDialogPage takes and holds a StringView meaning that the data
was dropped instantly and displayed garbage instead.
This commit is contained in:
Karol Kosek 2023-05-14 20:24:54 +02:00 • committed by Andreas Kling
parent 4de99d553e
commit bde96640ac
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/Spreadsheet/ImportDialog.cpp
View file

@ -186,7 +186,7 @@ ErrorOr<Vector<NonnullRefPtr<Sheet>>, DeprecatedString> ImportDialog::make_and_r
auto contents_or_error = file.read_until_eof(); auto contents_or_error = file.read_until_eof();
if (contents_or_error.is_error()) if (contents_or_error.is_error())
return DeprecatedString::formatted("{}", contents_or_error.release_error()); return DeprecatedString::formatted("{}", contents_or_error.release_error());
CSVImportDialogPage page { contents_or_error.release_value() }; CSVImportDialogPage page { contents_or_error.value() };
wizard->replace_page(page.page()); wizard->replace_page(page.page());
auto result = wizard->exec(); auto result = wizard->exec();