mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 03:17:35 +00:00
Kernel: Move process coredump metadata modification to the prctl syscall
This commit is contained in:
parent
822164a686
commit
be1d7c325a
8 changed files with 17 additions and 38 deletions
|
@ -155,7 +155,6 @@ enum class NeedsBigProcessLock {
|
|||
S(scheduler_set_parameters, NeedsBigProcessLock::No) \
|
||||
S(sendfd, NeedsBigProcessLock::No) \
|
||||
S(sendmsg, NeedsBigProcessLock::Yes) \
|
||||
S(set_coredump_metadata, NeedsBigProcessLock::No) \
|
||||
S(set_mmap_name, NeedsBigProcessLock::Yes) \
|
||||
S(set_process_name, NeedsBigProcessLock::No) \
|
||||
S(set_thread_name, NeedsBigProcessLock::No) \
|
||||
|
|
|
@ -10,3 +10,4 @@
|
|||
#define PR_GET_DUMPABLE 2
|
||||
#define PR_SET_NO_NEW_SYSCALL_REGION_ANNOTATIONS 3
|
||||
#define PR_GET_NO_NEW_SYSCALL_REGION_ANNOTATIONS 4
|
||||
#define PR_SET_COREDUMP_METADATA_VALUE 5
|
||||
|
|
|
@ -439,7 +439,6 @@ public:
|
|||
ErrorOr<FlatPtr> sys$disown(ProcessID);
|
||||
ErrorOr<FlatPtr> sys$allocate_tls(Userspace<char const*> initial_data, size_t);
|
||||
ErrorOr<FlatPtr> sys$prctl(int option, FlatPtr arg1, FlatPtr arg2);
|
||||
ErrorOr<FlatPtr> sys$set_coredump_metadata(Userspace<Syscall::SC_set_coredump_metadata_params const*>);
|
||||
ErrorOr<FlatPtr> sys$anon_create(size_t, int options);
|
||||
ErrorOr<FlatPtr> sys$statvfs(Userspace<Syscall::SC_statvfs_params const*> user_params);
|
||||
ErrorOr<FlatPtr> sys$fstatvfs(int fd, statvfs* buf);
|
||||
|
|
|
@ -25,7 +25,7 @@ ErrorOr<FlatPtr> Process::sys$prctl(int option, FlatPtr arg1, [[maybe_unused]] F
|
|||
return address_space().with([&](auto& space) -> ErrorOr<FlatPtr> {
|
||||
return space->enforces_syscall_regions();
|
||||
});
|
||||
case PR_SET_NO_NEW_SYSCALL_REGION_ANNOTATIONS:
|
||||
case PR_SET_NO_NEW_SYSCALL_REGION_ANNOTATIONS: {
|
||||
if (arg1 != 0 && arg1 != 1)
|
||||
return EINVAL;
|
||||
bool prohibit_new_annotated_syscall_regions = (arg1 == 1);
|
||||
|
@ -38,6 +38,19 @@ ErrorOr<FlatPtr> Process::sys$prctl(int option, FlatPtr arg1, [[maybe_unused]] F
|
|||
});
|
||||
return 0;
|
||||
}
|
||||
case PR_SET_COREDUMP_METADATA_VALUE: {
|
||||
auto params = TRY(copy_typed_from_user<Syscall::SC_set_coredump_metadata_params>(arg1));
|
||||
if (params.key.length == 0 || params.key.length > 16 * KiB)
|
||||
return EINVAL;
|
||||
if (params.value.length > 16 * KiB)
|
||||
return EINVAL;
|
||||
auto key = TRY(try_copy_kstring_from_user(params.key));
|
||||
auto value = TRY(try_copy_kstring_from_user(params.value));
|
||||
TRY(set_coredump_property(move(key), move(value)));
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
|
||||
return EINVAL;
|
||||
});
|
||||
}
|
||||
|
|
|
@ -52,19 +52,4 @@ ErrorOr<FlatPtr> Process::sys$set_process_name(Userspace<char const*> user_name,
|
|||
return 0;
|
||||
}
|
||||
|
||||
ErrorOr<FlatPtr> Process::sys$set_coredump_metadata(Userspace<Syscall::SC_set_coredump_metadata_params const*> user_params)
|
||||
{
|
||||
VERIFY_NO_PROCESS_BIG_LOCK(this);
|
||||
auto params = TRY(copy_typed_from_user(user_params));
|
||||
|
||||
if (params.key.length == 0 || params.key.length > 16 * KiB)
|
||||
return EINVAL;
|
||||
if (params.value.length > 16 * KiB)
|
||||
return EINVAL;
|
||||
auto key = TRY(try_copy_kstring_from_user(params.key));
|
||||
auto value = TRY(try_copy_kstring_from_user(params.value));
|
||||
TRY(set_coredump_property(move(key), move(value)));
|
||||
return 0;
|
||||
}
|
||||
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue