RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:47:45 +00:00
Code Issues Activity Actions

Profiler: Implement "Top functions" feature like Instruments.app has

Browse source 
This view mode takes every stack frame and turns it into a root in the
profile graph. This allows functions that are called from many places
to bubble up to the top. It's a very handy way to discover heavy things
in a profile that are otherwise obscured by having many callers.
This commit is contained in:
Andreas Kling 2020-10-19 15:04:54 +02:00
parent 46cc1f718e
commit be4005cb9e
3 changed files with 83 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

14
DevTools/Profiler/Profile.h
View file

@ -26,6 +26,7 @@
#pragma once
#include <AK/Bitmap.h>
#include <AK/JsonArray.h>
#include <AK/JsonObject.h>
#include <AK/JsonValue.h>
@ -44,6 +45,15 @@ public:
return adopt(*new ProfileNode(symbol, address, offset, timestamp));
}
// These functions are only relevant for root nodes
void will_track_seen_events(size_t profile_event_count)
{
if (m_seen_events.size() != profile_event_count)
m_seen_events = Bitmap::create(profile_event_count, false);
}
bool has_seen_event(size_t event_index) const { return m_seen_events.get(event_index); }
void did_see_event(size_t event_index) { m_seen_events.set(event_index, true); }
const String& symbol() const { return m_symbol; }
u32 address() const { return m_address; }
u32 offset() const { return m_offset; }
@ -113,6 +123,7 @@ private:
u64 m_timestamp { 0 };
Vector<NonnullRefPtr<ProfileNode>> m_children;
HashMap<FlatPtr, size_t> m_events_per_address;
Bitmap m_seen_events;
};
class Profile {
@ -158,6 +169,8 @@ public:
bool is_inverted() const { return m_inverted; }
void set_inverted(bool);
void set_show_top_functions(bool);
bool show_percentages() const { return m_show_percentages; }
void set_show_percentages(bool);
@ -188,5 +201,6 @@ private:
u32 m_deepest_stack_depth { 0 };
bool m_inverted { false };
bool m_show_top_functions { false };
bool m_show_percentages { false };
};