RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 00:17:46 +00:00
Code Issues Activity Actions

LibJS: Implement Temporal.Duration.prototype.nanoseconds

Browse source
This commit is contained in:
Linus Groh 2021-07-16 00:07:49 +01:00
parent 04e2d215a1
commit be5254dcac
4 changed files with 30 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h
View file

@ -244,6 +244,7 @@ namespace JS {
P(months) \
P(multiline) \
P(name) \
P(nanoseconds) \
P(next) \
P(now) \
P(of) \

14
Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp
View file

@ -34,6 +34,7 @@ void DurationPrototype::initialize(GlobalObject& global_object)
define_native_accessor(vm.names.seconds, seconds_getter, {}, Attribute::Configurable);
define_native_accessor(vm.names.milliseconds, milliseconds_getter, {}, Attribute::Configurable);
define_native_accessor(vm.names.microseconds, microseconds_getter, {}, Attribute::Configurable);
define_native_accessor(vm.names.nanoseconds, nanoseconds_getter, {}, Attribute::Configurable);
}
static Duration* typed_this(GlobalObject& global_object)
@ -166,4 +167,17 @@ JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::microseconds_getter)
return Value(duration->microseconds());
}
// 7.3.12 get Temporal.Duration.prototype.nanoseconds, https://tc39.es/proposal-temporal/#sec-get-temporal.duration.prototype.nanoseconds
JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::nanoseconds_getter)
{
// 1. Let duration be the this value.
// 2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]).
auto* duration = typed_this(global_object);
if (vm.exception())
return {};
// 3. Return duration.[[Nanoseconds]].
return Value(duration->nanoseconds());
}
}

1
Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h
View file

@ -28,6 +28,7 @@ private:
JS_DECLARE_NATIVE_FUNCTION(seconds_getter);
JS_DECLARE_NATIVE_FUNCTION(milliseconds_getter);
JS_DECLARE_NATIVE_FUNCTION(microseconds_getter);
JS_DECLARE_NATIVE_FUNCTION(nanoseconds_getter);
};
}

14
Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.nanoseconds.js Normal file
View file

@ -0,0 +1,14 @@
describe("correct behavior", () => {
test("basic functionality", () => {
const duration = new Temporal.Duration(0, 0, 0, 0, 0, 0, 0, 0, 0, 123);
expect(duration.nanoseconds).toBe(123);
});
});
test("errors", () => {
test("this value must be a Temporal.Duration object", () => {
expect(() => {
Reflect.get(Temporal.Duration.prototype, "nanoseconds", "foo");
}).toThrowWithMessage(TypeError, "Not a Temporal.Duration");
});
});