RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:38:11 +00:00
Code Issues Activity Actions

Kernel: Swap baud rate divisor registers in SerialDevice::set_baud

Browse source 
These were accidentally the wrong way around (LSB part of the divisor
into the MSB register, MSB part of the divisor into the LSB register)
as can be seen in the specification (and in the comments themselves)
This commit is contained in:
Idan Horowitz 2021-05-15 00:36:13 +03:00 • committed by Andreas Kling
parent 0e5aba16ef
commit be57c424f3
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Devices/SerialDevice.cpp
View file

@ -87,8 +87,8 @@ void SerialDevice::set_baud(Baud baud)
m_baud = baud;
IO::out8(m_base_addr + 3, IO::in8(m_base_addr + 3) | 0x80); // turn on DLAB
IO::out8(m_base_addr + 0, ((u8)(baud)) >> 2); // lower half of divisor
IO::out8(m_base_addr + 1, ((u8)(baud)) & 0xff); // upper half of divisor
IO::out8(m_base_addr + 0, ((u8)(baud)) & 0xff); // lower half of divisor
IO::out8(m_base_addr + 1, ((u8)(baud)) >> 2); // upper half of divisor
IO::out8(m_base_addr + 3, IO::in8(m_base_addr + 3) & 0x7f); // turn off DLAB
}