RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:27:45 +00:00
Code Issues Activity Actions

LibWebSocket: Make WebSocketImpl an abstract class

Browse source 
The LibCore sockets implementation becomes WebSocketImplSerenity.
This will allow us to create a custom WebSocketImpl subclass for Qt
to use in Ladybird.
This commit is contained in:
Andreas Kling 2022-11-08 18:40:33 +01:00
parent cc78a74c51
commit be5f6aa46e
6 changed files with 144 additions and 81 deletions
Download patch file Download diff file Expand all files Collapse all files

36
Userland/Libraries/LibWebSocket/Impl/WebSocketImpl.h
View file

@ -11,41 +11,29 @@
#include <AK/ByteBuffer.h>
#include <AK/Span.h>
#include <AK/String.h>
#include <LibCore/Object.h>
#include <LibWebSocket/ConnectionInfo.h>
namespace WebSocket {
class WebSocketImpl : public Core::Object {
C_OBJECT(WebSocketImpl);
class WebSocketImpl : public RefCounted<WebSocketImpl> {
public:
virtual ~WebSocketImpl() override = default;
explicit WebSocketImpl(Core::Object* parent = nullptr);
virtual ~WebSocketImpl();
void connect(ConnectionInfo const&);
bool can_read_line() { return MUST(m_socket->can_read_line()); }
ErrorOr<String> read_line(size_t size);
bool can_read() { return MUST(m_socket->can_read_without_blocking()); }
ErrorOr<ByteBuffer> read(int max_size);
bool send(ReadonlyBytes bytes) { return m_socket->write_or_error(bytes); }
bool eof() { return m_socket->is_eof(); }
void discard_connection()
{
m_socket.clear();
}
virtual void connect(ConnectionInfo const&) = 0;
virtual bool can_read_line() = 0;
virtual ErrorOr<String> read_line(size_t) = 0;
virtual bool can_read() = 0;
virtual ErrorOr<ByteBuffer> read(int max_size) = 0;
virtual bool send(ReadonlyBytes) = 0;
virtual bool eof() = 0;
virtual void discard_connection() = 0;
Function<void()> on_connected;
Function<void()> on_connection_error;
Function<void()> on_ready_to_read;
private:
OwnPtr<Core::Stream::BufferedSocketBase> m_socket;
protected:
WebSocketImpl();
};
}