RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-25 21:05:07 +00:00
Code Issues Activity Actions

LibSQL: Fix incorrect return types

Browse source 
Right now RefPtr<T> is way more lenient than it should be. That might
change in the future though.
This commit is contained in:
Gunnar Beutner 2021-05-05 21:53:34 +02:00 • committed by Andreas Kling
parent e8b508516a
commit beae2d5caa
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibSQL/Parser.cpp
View file

@ -104,7 +104,7 @@ NonnullRefPtr<CreateTable> Parser::parse_create_table_statement()
return create_ast_node<CreateTable>(move(schema_name), move(table_name), move(column_definitions), is_temporary, is_error_if_table_exists); return create_ast_node<CreateTable>(move(schema_name), move(table_name), move(column_definitions), is_temporary, is_error_if_table_exists);
} }
NonnullRefPtr<CreateTable> Parser::parse_alter_table_statement() NonnullRefPtr<AlterTable> Parser::parse_alter_table_statement()
{ {
// https://sqlite.org/lang_altertable.html // https://sqlite.org/lang_altertable.html
consume(TokenType::Alter); consume(TokenType::Alter);
@ -159,7 +159,7 @@ NonnullRefPtr<DropTable> Parser::parse_drop_table_statement()
return create_ast_node<DropTable>(move(schema_name), move(table_name), is_error_if_table_does_not_exist); return create_ast_node<DropTable>(move(schema_name), move(table_name), is_error_if_table_does_not_exist);
} }
NonnullRefPtr<Delete> Parser::parse_insert_statement(RefPtr<CommonTableExpressionList> common_table_expression_list) NonnullRefPtr<Insert> Parser::parse_insert_statement(RefPtr<CommonTableExpressionList> common_table_expression_list)
{ {
// https://sqlite.org/lang_insert.html // https://sqlite.org/lang_insert.html
consume(TokenType::Insert); consume(TokenType::Insert);
@ -209,7 +209,7 @@ NonnullRefPtr<Delete> Parser::parse_insert_statement(RefPtr<CommonTableExpressio
return create_ast_node<Insert>(move(common_table_expression_list), conflict_resolution, move(schema_name), move(table_name), move(alias), move(column_names)); return create_ast_node<Insert>(move(common_table_expression_list), conflict_resolution, move(schema_name), move(table_name), move(alias), move(column_names));
} }
NonnullRefPtr<Delete> Parser::parse_update_statement(RefPtr<CommonTableExpressionList> common_table_expression_list) NonnullRefPtr<Update> Parser::parse_update_statement(RefPtr<CommonTableExpressionList> common_table_expression_list)
{ {
// https://sqlite.org/lang_update.html // https://sqlite.org/lang_update.html
consume(TokenType::Update); consume(TokenType::Update);

6
Userland/Libraries/LibSQL/Parser.h
View file

@ -53,10 +53,10 @@ private:
NonnullRefPtr<Statement> parse_statement(); NonnullRefPtr<Statement> parse_statement();
NonnullRefPtr<Statement> parse_statement_with_expression_list(RefPtr<CommonTableExpressionList>); NonnullRefPtr<Statement> parse_statement_with_expression_list(RefPtr<CommonTableExpressionList>);
NonnullRefPtr<CreateTable> parse_create_table_statement(); NonnullRefPtr<CreateTable> parse_create_table_statement();
NonnullRefPtr<CreateTable> parse_alter_table_statement(); NonnullRefPtr<AlterTable> parse_alter_table_statement();
NonnullRefPtr<DropTable> parse_drop_table_statement(); NonnullRefPtr<DropTable> parse_drop_table_statement();
NonnullRefPtr<Delete> parse_insert_statement(RefPtr<CommonTableExpressionList>); NonnullRefPtr<Insert> parse_insert_statement(RefPtr<CommonTableExpressionList>);
NonnullRefPtr<Delete> parse_update_statement(RefPtr<CommonTableExpressionList>); NonnullRefPtr<Update> parse_update_statement(RefPtr<CommonTableExpressionList>);
NonnullRefPtr<Delete> parse_delete_statement(RefPtr<CommonTableExpressionList>); NonnullRefPtr<Delete> parse_delete_statement(RefPtr<CommonTableExpressionList>);
NonnullRefPtr<Select> parse_select_statement(RefPtr<CommonTableExpressionList>); NonnullRefPtr<Select> parse_select_statement(RefPtr<CommonTableExpressionList>);
NonnullRefPtr<CommonTableExpressionList> parse_common_table_expression_list(); NonnullRefPtr<CommonTableExpressionList> parse_common_table_expression_list();