RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:47:34 +00:00
Code Issues Activity Actions

LibJS: Require colon in object expression for non-identifier keys

Browse source 
{foo} is valid - {"foo"} or {1} is not.
This commit is contained in:
Linus Groh 2020-04-23 19:17:39 +01:00 • committed by Andreas Kling
parent 402ba20c36
commit bebd5c097c
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Parser.cpp
View file

@ -440,8 +440,10 @@ NonnullRefPtr<ObjectExpression> Parser::parse_object_expression()
while (!done() && !match(TokenType::CurlyClose)) { while (!done() && !match(TokenType::CurlyClose)) {
FlyString property_name; FlyString property_name;
auto need_colon = true;
if (match_identifier_name()) { if (match_identifier_name()) {
property_name = consume().value(); property_name = consume().value();
need_colon = false;
} else if (match(TokenType::StringLiteral)) { } else if (match(TokenType::StringLiteral)) {
property_name = consume(TokenType::StringLiteral).string_value(); property_name = consume(TokenType::StringLiteral).string_value();
} else if (match(TokenType::NumericLiteral)) { } else if (match(TokenType::NumericLiteral)) {
@ -457,7 +459,7 @@ NonnullRefPtr<ObjectExpression> Parser::parse_object_expression()
continue; continue;
} }
if (match(TokenType::Colon)) { if (need_colon || match(TokenType::Colon)) {
consume(TokenType::Colon); consume(TokenType::Colon);
properties.set(property_name, parse_expression(0)); properties.set(property_name, parse_expression(0));
} else { } else {