RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:07:44 +00:00
Code Issues Activity Actions

LibWeb: Parse and plumb background-position-x/y

Browse source 
This parses the new background-position-x/y longhands and properly
hooks up them up. This requires converting PositionStyleValue to
just contain two EdgeStyleValues so that it can be easily expanded
into the longhands.
This commit is contained in:
MacDue 2023-04-03 00:04:00 +01:00 • committed by Andreas Kling
parent 2a659693bc
commit bed55ac669
7 changed files with 135 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Userland/Libraries/LibWeb/CSS/StyleValues/PositionStyleValue.h
View file

@ -17,33 +17,29 @@ namespace Web::CSS {
class PositionStyleValue final : public StyleValueWithDefaultOperators<PositionStyleValue> {
public:
static ValueComparingNonnullRefPtr<PositionStyleValue> create(PositionEdge edge_x, LengthPercentage const& offset_x, PositionEdge edge_y, LengthPercentage const& offset_y)
static ValueComparingNonnullRefPtr<PositionStyleValue> create(ValueComparingNonnullRefPtr<StyleValue> egde_x, ValueComparingNonnullRefPtr<StyleValue> edge_y)
{
return adopt_ref(*new PositionStyleValue(edge_x, offset_x, edge_y, offset_y));
return adopt_ref(*new PositionStyleValue(move(egde_x), move(edge_y)));
}
virtual ~PositionStyleValue() override = default;
PositionEdge edge_x() const { return m_properties.edge_x; }
LengthPercentage const& offset_x() const { return m_properties.offset_x; }
PositionEdge edge_y() const { return m_properties.edge_y; }
LengthPercentage const& offset_y() const { return m_properties.offset_y; }
ValueComparingNonnullRefPtr<StyleValue> edge_x() const { return m_properties.edge_x; }
ValueComparingNonnullRefPtr<StyleValue> edge_y() const { return m_properties.edge_y; }
virtual ErrorOr<String> to_string() const override;
bool properties_equal(PositionStyleValue const& other) const { return m_properties == other.m_properties; }
private:
PositionStyleValue(PositionEdge edge_x, LengthPercentage const& offset_x, PositionEdge edge_y, LengthPercentage const& offset_y)
PositionStyleValue(ValueComparingNonnullRefPtr<StyleValue> edge_x, ValueComparingNonnullRefPtr<StyleValue> edge_y)
: StyleValueWithDefaultOperators(Type::Position)
, m_properties { .edge_x = edge_x, .offset_x = offset_x, .edge_y = edge_y, .offset_y = offset_y }
, m_properties { .edge_x = edge_x, .edge_y = edge_y }
{
}
struct Properties {
PositionEdge edge_x;
LengthPercentage offset_x;
PositionEdge edge_y;
LengthPercentage offset_y;
ValueComparingNonnullRefPtr<StyleValue> edge_x;
ValueComparingNonnullRefPtr<StyleValue> edge_y;
bool operator==(Properties const&) const = default;
} m_properties;
};