RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-10 09:47:35 +00:00
Code Issues Activity Actions

AK: Rename Bitmap::try_create() to ::create()

Browse source 
This is step 1 to removing `must_create()`.
This commit is contained in:
Sam Atkins 2022-12-20 16:34:13 +00:00 • committed by Andreas Kling
parent c4e8509aac
commit bed5961fc2
5 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
AK/Bitmap.h
View file

@ -22,7 +22,7 @@ class Bitmap : public BitmapView {
AK_MAKE_NONCOPYABLE(Bitmap); AK_MAKE_NONCOPYABLE(Bitmap);
public: public:
static ErrorOr<Bitmap> try_create(size_t size, bool default_value) static ErrorOr<Bitmap> create(size_t size, bool default_value)
{ {
VERIFY(size != 0); VERIFY(size != 0);
@ -37,7 +37,7 @@ public:
static Bitmap must_create(size_t size, bool default_value) static Bitmap must_create(size_t size, bool default_value)
{ {
return MUST(try_create(size, default_value)); return MUST(create(size, default_value));
} }
Bitmap() = default; Bitmap() = default;

2
Kernel/Bus/PCI/Controller/HostController.cpp
View file

@ -14,7 +14,7 @@ namespace Kernel::PCI {
HostController::HostController(PCI::Domain const& domain) HostController::HostController(PCI::Domain const& domain)
: m_domain(domain) : m_domain(domain)
, m_enumerated_buses(Bitmap::try_create(256, false).release_value_but_fixme_should_propagate_errors()) , m_enumerated_buses(Bitmap::create(256, false).release_value_but_fixme_should_propagate_errors())
{ {
} }

2
Kernel/Memory/AnonymousVMObject.cpp
View file

@ -279,7 +279,7 @@ NonnullRefPtr<PhysicalPage> AnonymousVMObject::allocate_committed_page(Badge<Reg
ErrorOr<void> AnonymousVMObject::ensure_cow_map() ErrorOr<void> AnonymousVMObject::ensure_cow_map()
{ {
if (m_cow_map.is_null()) if (m_cow_map.is_null())
m_cow_map = TRY(Bitmap::try_create(page_count(), true)); m_cow_map = TRY(Bitmap::create(page_count(), true));
return {}; return {};
} }

4
Kernel/Memory/PrivateInodeVMObject.cpp
View file

@ -23,14 +23,14 @@ ErrorOr<NonnullLockRefPtr<PrivateInodeVMObject>> PrivateInodeVMObject::try_creat
auto size = max(inode.size(), (offset + range_size)); auto size = max(inode.size(), (offset + range_size));
VERIFY(size > 0); VERIFY(size > 0);
auto new_physical_pages = TRY(VMObject::try_create_physical_pages(size)); auto new_physical_pages = TRY(VMObject::try_create_physical_pages(size));
auto dirty_pages = TRY(Bitmap::try_create(new_physical_pages.size(), false)); auto dirty_pages = TRY(Bitmap::create(new_physical_pages.size(), false));
return adopt_nonnull_lock_ref_or_enomem(new (nothrow) PrivateInodeVMObject(inode, move(new_physical_pages), move(dirty_pages))); return adopt_nonnull_lock_ref_or_enomem(new (nothrow) PrivateInodeVMObject(inode, move(new_physical_pages), move(dirty_pages)));
} }
ErrorOr<NonnullLockRefPtr<VMObject>> PrivateInodeVMObject::try_clone() ErrorOr<NonnullLockRefPtr<VMObject>> PrivateInodeVMObject::try_clone()
{ {
auto new_physical_pages = TRY(this->try_clone_physical_pages()); auto new_physical_pages = TRY(this->try_clone_physical_pages());
auto dirty_pages = TRY(Bitmap::try_create(new_physical_pages.size(), false)); auto dirty_pages = TRY(Bitmap::create(new_physical_pages.size(), false));
return adopt_nonnull_lock_ref_or_enomem<VMObject>(new (nothrow) PrivateInodeVMObject(*this, move(new_physical_pages), move(dirty_pages))); return adopt_nonnull_lock_ref_or_enomem<VMObject>(new (nothrow) PrivateInodeVMObject(*this, move(new_physical_pages), move(dirty_pages)));
} }

4
Kernel/Memory/SharedInodeVMObject.cpp
View file

@ -26,7 +26,7 @@ ErrorOr<NonnullLockRefPtr<SharedInodeVMObject>> SharedInodeVMObject::try_create_
if (auto shared_vmobject = inode.shared_vmobject()) if (auto shared_vmobject = inode.shared_vmobject())
return shared_vmobject.release_nonnull(); return shared_vmobject.release_nonnull();
auto new_physical_pages = TRY(VMObject::try_create_physical_pages(size)); auto new_physical_pages = TRY(VMObject::try_create_physical_pages(size));
auto dirty_pages = TRY(Bitmap::try_create(new_physical_pages.size(), false)); auto dirty_pages = TRY(Bitmap::create(new_physical_pages.size(), false));
auto vmobject = TRY(adopt_nonnull_lock_ref_or_enomem(new (nothrow) SharedInodeVMObject(inode, move(new_physical_pages), move(dirty_pages)))); auto vmobject = TRY(adopt_nonnull_lock_ref_or_enomem(new (nothrow) SharedInodeVMObject(inode, move(new_physical_pages), move(dirty_pages))));
TRY(vmobject->inode().set_shared_vmobject(*vmobject)); TRY(vmobject->inode().set_shared_vmobject(*vmobject));
return vmobject; return vmobject;
@ -35,7 +35,7 @@ ErrorOr<NonnullLockRefPtr<SharedInodeVMObject>> SharedInodeVMObject::try_create_
ErrorOr<NonnullLockRefPtr<VMObject>> SharedInodeVMObject::try_clone() ErrorOr<NonnullLockRefPtr<VMObject>> SharedInodeVMObject::try_clone()
{ {
auto new_physical_pages = TRY(this->try_clone_physical_pages()); auto new_physical_pages = TRY(this->try_clone_physical_pages());
auto dirty_pages = TRY(Bitmap::try_create(new_physical_pages.size(), false)); auto dirty_pages = TRY(Bitmap::create(new_physical_pages.size(), false));
return adopt_nonnull_lock_ref_or_enomem<VMObject>(new (nothrow) SharedInodeVMObject(*this, move(new_physical_pages), move(dirty_pages))); return adopt_nonnull_lock_ref_or_enomem<VMObject>(new (nothrow) SharedInodeVMObject(*this, move(new_physical_pages), move(dirty_pages)));
} }