mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 14:17:36 +00:00
Kernel: Make syscalls that take a buffer size use ssize_t instead of size_t.
Dealing with the unsigned overflow propagation here just seems unreasonably error prone. Let's limit ourselves to 2GB buffer sizes instead.
This commit is contained in:
parent
5af4e622b9
commit
beda478821
40 changed files with 144 additions and 136 deletions
|
@ -1,4 +1,4 @@
|
|||
#include "DoubleBuffer.h"
|
||||
#include <Kernel/DoubleBuffer.h>
|
||||
|
||||
inline void DoubleBuffer::compute_emptiness()
|
||||
{
|
||||
|
@ -17,24 +17,22 @@ void DoubleBuffer::flip()
|
|||
compute_emptiness();
|
||||
}
|
||||
|
||||
ssize_t DoubleBuffer::write(const byte* data, size_t size)
|
||||
ssize_t DoubleBuffer::write(const byte* data, ssize_t size)
|
||||
{
|
||||
ASSERT_INTERRUPTS_ENABLED();
|
||||
LOCKER(m_lock);
|
||||
m_write_buffer->append(data, size);
|
||||
compute_emptiness();
|
||||
return size;
|
||||
}
|
||||
|
||||
ssize_t DoubleBuffer::read(byte* data, size_t size)
|
||||
ssize_t DoubleBuffer::read(byte* data, ssize_t size)
|
||||
{
|
||||
ASSERT_INTERRUPTS_ENABLED();
|
||||
LOCKER(m_lock);
|
||||
if (m_read_buffer_index >= m_read_buffer->size() && !m_write_buffer->is_empty())
|
||||
flip();
|
||||
if (m_read_buffer_index >= m_read_buffer->size())
|
||||
return 0;
|
||||
ssize_t nread = min(m_read_buffer->size() - m_read_buffer_index, size);
|
||||
ssize_t nread = min((ssize_t)m_read_buffer->size() - m_read_buffer_index, size);
|
||||
memcpy(data, m_read_buffer->data() + m_read_buffer_index, nread);
|
||||
m_read_buffer_index += nread;
|
||||
compute_emptiness();
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue