From bee316cfbe7aadf7e3afd7d6a6881807333d16b2 Mon Sep 17 00:00:00 2001 From: Optimoos Date: Sun, 18 Jun 2023 17:01:29 -0400 Subject: [PATCH] LibGfx: Remove unneeded TODO in BMPLoader There was a TODO questioning whether breaking on >4bpp images was the correct behaviour when RLE4 was detected. There is no indication in the spec that RLE4 can be used with anything >4bpp, so I believe this doesn't require additional follow-up. MS Spec: https://learn.microsoft.com/en-us/windows/win32/gdi/bitmap-compression --- Userland/Libraries/LibGfx/ImageFormats/BMPLoader.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/Userland/Libraries/LibGfx/ImageFormats/BMPLoader.cpp b/Userland/Libraries/LibGfx/ImageFormats/BMPLoader.cpp index f831250b9a..062b937d9e 100644 --- a/Userland/Libraries/LibGfx/ImageFormats/BMPLoader.cpp +++ b/Userland/Libraries/LibGfx/ImageFormats/BMPLoader.cpp @@ -438,7 +438,6 @@ static bool check_for_invalid_bitmask_combinations(BMPLoadingContext& context) return false; break; case Compression::RLE4: - // TODO: This is a guess if (bpp > 4) return false; break;