RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:07:45 +00:00
Code Issues Activity Actions

LibIPC: Use a simpler encoding for arithmetic values

Browse source 
This is less code, but mostly serves to reduce the amount of methods to
be added to IPC::MessageBuffer in an upcoming patch.
This commit is contained in:
Timothy Flynn 2024-01-02 20:24:28 -05:00 • committed by Andreas Kling
parent 3adf01b816
commit bf15b66117
1 changed files with 1 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

31
Userland/Libraries/LibIPC/Encoder.h
View file

@ -40,11 +40,6 @@ public:
return m_buffer.data.try_ensure_capacity(m_buffer.data.size() + capacity); return m_buffer.data.try_ensure_capacity(m_buffer.data.size() + capacity);
} }
void append(u8 value)
{
m_buffer.data.unchecked_append(value);
}
ErrorOr<void> append(u8 const* values, size_t count) ErrorOr<void> append(u8 const* values, size_t count)
{ {
TRY(extend_capacity(count)); TRY(extend_capacity(count));
@ -67,31 +62,7 @@ private:
template<Arithmetic T> template<Arithmetic T>
ErrorOr<void> encode(Encoder& encoder, T const& value) ErrorOr<void> encode(Encoder& encoder, T const& value)
{ {
TRY(encoder.extend_capacity(sizeof(T))); TRY(encoder.append(reinterpret_cast<u8 const*>(&value), sizeof(value)));
if constexpr (sizeof(T) == 1) {
encoder.append(static_cast<u8>(value));
} else if constexpr (sizeof(T) == 2) {
encoder.append(static_cast<u8>(value));
encoder.append(static_cast<u8>(value >> 8));
} else if constexpr (sizeof(T) == 4) {
encoder.append(static_cast<u8>(value));
encoder.append(static_cast<u8>(value >> 8));
encoder.append(static_cast<u8>(value >> 16));
encoder.append(static_cast<u8>(value >> 24));
} else if constexpr (sizeof(T) == 8) {
encoder.append(static_cast<u8>(value));
encoder.append(static_cast<u8>(value >> 8));
encoder.append(static_cast<u8>(value >> 16));
encoder.append(static_cast<u8>(value >> 24));
encoder.append(static_cast<u8>(value >> 32));
encoder.append(static_cast<u8>(value >> 40));
encoder.append(static_cast<u8>(value >> 48));
encoder.append(static_cast<u8>(value >> 56));
} else {
static_assert(DependentFalse<T>);
}
return {}; return {};
} }