RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 22:07:35 +00:00
Code Issues Activity Actions

LibWeb: Add vertical border heights to tr

Browse source 
tr y offset is not being computed correctly.
This is causing errors in hit testing since
td and tr are misaligned.
This commit is contained in:
Haikal Zain 2023-07-01 13:30:42 +10:00 • committed by Andreas Kling
parent 5775993a2a
commit bf16618fba
15 changed files with 34 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Tests/LibWeb/Layout/expected/table/rowspan.txt
View file

@ -36,7 +36,7 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tr> at (10,29.46875) content-size 221.359375x19.46875 table-row children: not-inline
Box <tr> at (10,31.46875) content-size 221.359375x19.46875 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (11,43.203125) content-size 70.046875x17.46875 table-cell [BFC] children: inline
@ -62,7 +62,7 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tr> at (10,48.9375) content-size 221.359375x19.46875 table-row children: not-inline
Box <tr> at (10,52.9375) content-size 221.359375x19.46875 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (85.046875,53.9375) content-size 72.515625x17.46875 table-cell [BFC] children: inline
@ -81,7 +81,7 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tr> at (10,68.40625) content-size 221.359375x19.46875 table-row children: not-inline
Box <tr> at (10,74.40625) content-size 221.359375x19.46875 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (11,75.40625) content-size 70.046875x17.46875 table-cell [BFC] children: inline