RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:48:11 +00:00
Code Issues Activity Actions

Shell: Make run_command() return a NonnullRefPtrVector<Job>

Browse source 
This never returns null Job pointers.
This commit is contained in:
Andreas Kling 2020-08-06 13:44:30 +02:00
parent 3055f73d48
commit bf2cd9374c
4 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Shell/Shell.cpp
View file

@ -588,9 +588,9 @@ RefPtr<Job> Shell::run_command(const AST::Command& command)
return *job;
}
Vector<RefPtr<Job>> Shell::run_commands(Vector<AST::Command>& commands)
NonnullRefPtrVector<Job> Shell::run_commands(Vector<AST::Command>& commands)
{
Vector<RefPtr<Job>> jobs_to_wait_for;
NonnullRefPtrVector<Job> jobs_to_wait_for;
for (auto& command : commands) {
#ifdef SH_DEBUG
@ -618,10 +618,10 @@ Vector<RefPtr<Job>> Shell::run_commands(Vector<AST::Command>& commands)
if (command.should_wait) {
block_on_job(job);
if (!job->is_suspended())
jobs_to_wait_for.append(job);
jobs_to_wait_for.append(*job);
} else {
if (command.is_pipe_source) {
jobs_to_wait_for.append(job);
jobs_to_wait_for.append(*job);
} else if (command.should_notify_if_in_background) {
job->set_running_in_background(true);
restore_ios();