From bf33b5df6e12ead8f8216e0c839a6f15ea0cf37a Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 23 May 2021 09:22:51 +0200 Subject: [PATCH] WebSocket: Remove unnecessary greet() message --- Userland/Libraries/LibProtocol/WebSocketClient.cpp | 1 - Userland/Services/WebSocket/ClientConnection.cpp | 4 ---- Userland/Services/WebSocket/ClientConnection.h | 1 - Userland/Services/WebSocket/WebSocketServer.ipc | 3 --- 4 files changed, 9 deletions(-) diff --git a/Userland/Libraries/LibProtocol/WebSocketClient.cpp b/Userland/Libraries/LibProtocol/WebSocketClient.cpp index 4b07f2198d..3b28487533 100644 --- a/Userland/Libraries/LibProtocol/WebSocketClient.cpp +++ b/Userland/Libraries/LibProtocol/WebSocketClient.cpp @@ -17,7 +17,6 @@ WebSocketClient::WebSocketClient() void WebSocketClient::handshake() { - greet(); } RefPtr WebSocketClient::connect(const URL& url, const String& origin, const Vector& protocols, const Vector& extensions, const HashMap& request_headers) diff --git a/Userland/Services/WebSocket/ClientConnection.cpp b/Userland/Services/WebSocket/ClientConnection.cpp index ee9921697f..c02a4a022b 100644 --- a/Userland/Services/WebSocket/ClientConnection.cpp +++ b/Userland/Services/WebSocket/ClientConnection.cpp @@ -31,10 +31,6 @@ void ClientConnection::die() Core::EventLoop::current().quit(0); } -void ClientConnection::greet() -{ -} - Messages::WebSocketServer::ConnectResponse ClientConnection::connect(URL const& url, String const& origin, Vector const& protocols, Vector const& extensions, IPC::Dictionary const& additional_request_headers) { diff --git a/Userland/Services/WebSocket/ClientConnection.h b/Userland/Services/WebSocket/ClientConnection.h index 41ef9b4fcf..8f7a602af3 100644 --- a/Userland/Services/WebSocket/ClientConnection.h +++ b/Userland/Services/WebSocket/ClientConnection.h @@ -25,7 +25,6 @@ public: virtual void die() override; private: - virtual void greet() override; virtual Messages::WebSocketServer::ConnectResponse connect(URL const&, String const&, Vector const&, Vector const&, IPC::Dictionary const&) override; virtual Messages::WebSocketServer::ReadyStateResponse ready_state(i32) override; virtual void send(i32, bool, ByteBuffer const&) override; diff --git a/Userland/Services/WebSocket/WebSocketServer.ipc b/Userland/Services/WebSocket/WebSocketServer.ipc index dea7b19d21..a77da4e85b 100644 --- a/Userland/Services/WebSocket/WebSocketServer.ipc +++ b/Userland/Services/WebSocket/WebSocketServer.ipc @@ -1,8 +1,5 @@ endpoint WebSocketServer { - // Basic protocol - greet() => () - // Connection API connect(URL url, String origin, Vector protocols, Vector extensions, IPC::Dictionary additional_request_headers) => (i32 connection_id) ready_state(i32 connection_id) => (u32 ready_state)