RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:47:34 +00:00
Code Issues Activity Actions

LibWeb: Make BrowsingContext store Page member as NonnullGCPtr

Browse source 
No need to use WeakPtr anymore.

Co-Authored-By: Andreas Kling <kling@serenityos.org>
This commit is contained in:
Andreas Kling 2023-06-26 06:58:10 +02:00
parent 7c926d04b7
commit bf4c8f4a09
2 changed files with 10 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/HTML/BrowsingContext.h
View file

@ -43,8 +43,8 @@ public:
JS::NonnullGCPtr<DOM::Document> document;
};
static WebIDL::ExceptionOr<BrowsingContextAndDocument> create_a_new_browsing_context_and_document(Page& page, JS::GCPtr<DOM::Document> creator, JS::GCPtr<DOM::Element> embedder, JS::NonnullGCPtr<BrowsingContextGroup> group);
static WebIDL::ExceptionOr<BrowsingContextAndDocument> create_a_new_auxiliary_browsing_context_and_document(Page& page, JS::NonnullGCPtr<HTML::BrowsingContext> opener);
static WebIDL::ExceptionOr<BrowsingContextAndDocument> create_a_new_browsing_context_and_document(JS::NonnullGCPtr<Page> page, JS::GCPtr<DOM::Document> creator, JS::GCPtr<DOM::Element> embedder, JS::NonnullGCPtr<BrowsingContextGroup> group);
static WebIDL::ExceptionOr<BrowsingContextAndDocument> create_a_new_auxiliary_browsing_context_and_document(JS::NonnullGCPtr<Page> page, JS::NonnullGCPtr<HTML::BrowsingContext> opener);
virtual ~BrowsingContext() override;
@ -183,13 +183,13 @@ public:
virtual void set_window_handle(String handle) override { m_window_handle = move(handle); }
private:
explicit BrowsingContext(Page&, HTML::NavigableContainer*);
explicit BrowsingContext(JS::NonnullGCPtr<Page>, HTML::NavigableContainer*);
virtual void visit_edges(Cell::Visitor&) override;
void reset_cursor_blink_cycle();
WeakPtr<Page> m_page;
JS::NonnullGCPtr<Page> m_page;
Web::EventHandler m_event_handler;