RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:58:11 +00:00
Code Issues Activity Actions

AK+Kernel: Make BitmapView read-only

Browse source
This commit is contained in:
Ben Wiederhake 2021-11-06 15:56:10 +01:00 • committed by Andreas Kling
parent 850db15d66
commit bf7a2ff941
3 changed files with 2 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

1
AK/Bitmap.h
View file

@ -37,7 +37,6 @@ public:
{ {
} }
[[nodiscard]] BitmapView view() { return { m_data, m_size }; }
[[nodiscard]] BitmapView const view() const { return { m_data, m_size }; } [[nodiscard]] BitmapView const view() const { return { m_data, m_size }; }
Bitmap(Bitmap&& other) Bitmap(Bitmap&& other)

8
AK/BitmapView.h
View file

@ -32,14 +32,6 @@ public:
VERIFY(index < m_size); VERIFY(index < m_size);
return 0 != (m_data[index / 8] & (1u << (index % 8))); return 0 != (m_data[index / 8] & (1u << (index % 8)));
} }
void set(size_t index, bool value) const
{
VERIFY(index < m_size);
if (value)
m_data[index / 8] |= static_cast<u8>((1u << (index % 8)));
else
m_data[index / 8] &= static_cast<u8>(~(1u << (index % 8)));
}
size_t count_slow(bool value) const size_t count_slow(bool value) const
{ {

4
Kernel/FileSystem/Ext2FileSystem.h
View file

@ -6,7 +6,7 @@
#pragma once #pragma once
#include <AK/BitmapView.h> #include <AK/Bitmap.h>
#include <AK/HashMap.h> #include <AK/HashMap.h>
#include <Kernel/FileSystem/BlockBasedFileSystem.h> #include <Kernel/FileSystem/BlockBasedFileSystem.h>
#include <Kernel/FileSystem/Inode.h> #include <Kernel/FileSystem/Inode.h>
@ -176,7 +176,7 @@ private:
BlockIndex bitmap_block_index { 0 }; BlockIndex bitmap_block_index { 0 };
bool dirty { false }; bool dirty { false };
NonnullOwnPtr<KBuffer> buffer; NonnullOwnPtr<KBuffer> buffer;
BitmapView bitmap(u32 blocks_per_group) { return BitmapView { buffer->data(), blocks_per_group }; } Bitmap bitmap(u32 blocks_per_group) { return Bitmap { buffer->data(), blocks_per_group }; }
}; };
ErrorOr<CachedBitmap*> get_bitmap_block(BlockIndex); ErrorOr<CachedBitmap*> get_bitmap_block(BlockIndex);