RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 19:12:43 +00:00
Code Issues Activity Actions

LibWeb: Visit constructor callback in CustomElementDefinition

Browse source
This commit is contained in:
Aliaksandr Kalenik 2024-03-11 19:24:43 +01:00 • committed by Alexander Kalenik
parent 3b4230e0b0
commit bf8bbea209
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibWeb/HTML/CustomElements/CustomElementDefinition.cpp
View file

@ -11,6 +11,7 @@ namespace Web::HTML {
void CustomElementDefinition::visit_edges(Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_constructor);
for (auto& callback : m_lifecycle_callbacks)
visitor.visit(callback.value);
}

4
Userland/Libraries/LibWeb/HTML/CustomElements/CustomElementDefinition.h
View file

@ -51,7 +51,7 @@ private:
CustomElementDefinition(String const& name, String const& local_name, WebIDL::CallbackType& constructor, Vector<String>&& observed_attributes, LifecycleCallbacksStorage&& lifecycle_callbacks, bool form_associated, bool disable_internals, bool disable_shadow)
: m_name(name)
, m_local_name(local_name)
, m_constructor(JS::make_handle(constructor))
, m_constructor(constructor)
, m_observed_attributes(move(observed_attributes))
, m_lifecycle_callbacks(move(lifecycle_callbacks))
, m_form_associated(form_associated)
@ -74,7 +74,7 @@ private:
// https://html.spec.whatwg.org/multipage/custom-elements.html#concept-custom-element-definition-constructor
// A Web IDL CustomElementConstructor callback function type value wrapping the custom element constructor
JS::Handle<WebIDL::CallbackType> m_constructor;
JS::NonnullGCPtr<WebIDL::CallbackType> m_constructor;
// https://html.spec.whatwg.org/multipage/custom-elements.html#concept-custom-element-definition-observed-attributes
// A list of observed attributes