From bfa378660be6982397540ff9ece73049e4c0b195 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Sun, 13 Nov 2022 14:37:53 +0000 Subject: [PATCH] LibWeb: Add a clarifying comment to XHR::m_response_object Trying to change this to a JS::Object didn't quite work, so let's add a helpful comment instead. --- Userland/Libraries/LibWeb/XHR/XMLHttpRequest.h | 1 + 1 file changed, 1 insertion(+) diff --git a/Userland/Libraries/LibWeb/XHR/XMLHttpRequest.h b/Userland/Libraries/LibWeb/XHR/XMLHttpRequest.h index ced188af93..c18da3f167 100644 --- a/Userland/Libraries/LibWeb/XHR/XMLHttpRequest.h +++ b/Userland/Libraries/LibWeb/XHR/XMLHttpRequest.h @@ -161,6 +161,7 @@ private: // https://xhr.spec.whatwg.org/#response-object // response object // An object, failure, or null, initially null. + // NOTE: This needs to be a JS::Value as the JSON response might not actually be an object. Variant m_response_object; // FIXME: https://xhr.spec.whatwg.org/#xmlhttprequest-fetch-controller