From bfb527e61445865f901eab44aaf6b4394f8a5372 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 26 Oct 2023 15:13:26 +0200 Subject: [PATCH] LibJS/JIT: Call throw_if_needed_for_call() in cxx_call() This allows test-js to run to completion (although we do still have some bugs to track down.) --- Userland/Libraries/LibJS/JIT/Compiler.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibJS/JIT/Compiler.cpp b/Userland/Libraries/LibJS/JIT/Compiler.cpp index 929d253cc7..e0c067a2e0 100644 --- a/Userland/Libraries/LibJS/JIT/Compiler.cpp +++ b/Userland/Libraries/LibJS/JIT/Compiler.cpp @@ -751,8 +751,8 @@ void Compiler::compile_put_by_value(Bytecode::Op::PutByValue const& op) static Value cxx_call(VM& vm, Value callee, u32 first_argument_index, u32 argument_count, Value this_value, Bytecode::Op::CallType call_type) { - // FIXME: Uncomment this and deal with it. - // TRY_OR_SET_EXCEPTION(throw_if_needed_for_call(vm.bytecode_interpreter(), *this, callee)); + // FIXME: Get the expression_string() here as well. + TRY_OR_SET_EXCEPTION(throw_if_needed_for_call(vm.bytecode_interpreter(), callee, call_type, {})); MarkedVector argument_values(vm.heap()); argument_values.ensure_capacity(argument_count);