RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-28 08:35:09 +00:00
Code Issues Activity Actions

LibWeb: Treat percentage heights as "auto" if unresolvable

Browse source 
If the containing block has indefinite height, we can't resolve
percentage heights against it. Instead of treating it as 0 by accident,
let's treat it as "auto" on purpose.

This brings back the cheek borders on Acid2.
This commit is contained in:
Andreas Kling 2022-09-09 15:10:11 +02:00
parent b7d8fbbd70
commit bfcb4d88cf
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp
View file

@ -318,10 +318,13 @@ float BlockFormattingContext::compute_theoretical_height(LayoutState const& stat
if (is<ReplacedBox>(box)) {
height = compute_height_for_replaced_element(state, verify_cast<ReplacedBox>(box));
} else {
if (box.computed_values().height().is_auto())
// NOTE: We treat percentage heights as "auto" if the containing block has indefinite height.
if (box.computed_values().height().is_auto()
|| (box.computed_values().height().is_percentage() && !state.get(*box.containing_block()).has_definite_height())) {
height = compute_auto_height_for_block_level_element(state, box);
else
} else {
height = computed_values.height().resolved(box, containing_block_height).to_px(box);
}
}
auto specified_max_height = computed_values.max_height().resolved(box, containing_block_height).resolved(box);