RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:17:45 +00:00
Code Issues Activity Actions

LibGUI: Make GUI::Frame have the 2px sunken container look by default

Browse source 
The overwhelming majority of GUI::Frame users set the same appearance,
so let's just make it the default.
This commit is contained in:
Andreas Kling 2020-02-23 11:09:20 +01:00
parent 3d20da9ee4
commit bfd86c4631
27 changed files with 7 additions and 91 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibGUI/AbstractTableView.cpp
View file

@ -42,10 +42,6 @@ static const int minimum_column_width = 2;
AbstractTableView::AbstractTableView(Widget* parent)
: AbstractView(parent)
{
set_frame_shape(Gfx::FrameShape::Container);
set_frame_shadow(Gfx::FrameShadow::Sunken);
set_frame_thickness(2);
set_should_hide_unnecessary_scrollbars(true);
}

4
Libraries/LibGUI/ColumnsView.cpp
View file

@ -53,10 +53,6 @@ ColumnsView::ColumnsView(Widget* parent)
set_fill_with_background_color(true);
set_background_role(ColorRole::Base);
set_foreground_role(ColorRole::BaseText);
set_frame_shape(Gfx::FrameShape::Container);
set_frame_shadow(Gfx::FrameShadow::Sunken);
set_frame_thickness(2);
m_columns.append({ {}, 0 });
}

3
Libraries/LibGUI/FilePicker.cpp
View file

@ -225,9 +225,6 @@ FilePicker::FilePicker(Mode mode, const StringView& file_name, const StringView&
auto preview_container = horizontal_container->add<Frame>();
preview_container->set_size_policy(SizePolicy::Fixed, SizePolicy::Fill);
preview_container->set_preferred_size(180, 0);
preview_container->set_frame_shape(Gfx::FrameShape::Container);
preview_container->set_frame_shadow(Gfx::FrameShadow::Sunken);
preview_container->set_frame_thickness(2);
preview_container->set_layout(make<VerticalBoxLayout>());
preview_container->layout()->set_margins({ 8, 8, 8, 8 });

3
Libraries/LibGUI/Frame.cpp
View file

@ -34,6 +34,9 @@ namespace GUI {
Frame::Frame(Widget* parent)
: Widget(parent)
{
set_frame_thickness(2);
set_frame_shape(Gfx::FrameShape::Container);
set_frame_shadow(Gfx::FrameShadow::Sunken);
}
Frame::~Frame()

3
Libraries/LibGUI/ItemView.cpp
View file

@ -42,9 +42,6 @@ ItemView::ItemView(Widget* parent)
{
set_background_role(ColorRole::Base);
set_foreground_role(ColorRole::BaseText);
set_frame_shape(Gfx::FrameShape::Container);
set_frame_shadow(Gfx::FrameShadow::Sunken);
set_frame_thickness(2);
horizontal_scrollbar().set_visible(false);
}

5
Libraries/LibGUI/Label.cpp
View file

@ -33,7 +33,7 @@
namespace GUI {
Label::Label(Widget* parent)
: Frame(parent)
: Label({}, parent)
{
}
@ -41,6 +41,9 @@ Label::Label(const StringView& text, Widget* parent)
: Frame(parent)
, m_text(text)
{
set_frame_thickness(0);
set_frame_shadow(Gfx::FrameShadow::Plain);
set_frame_shape(Gfx::FrameShape::NoFrame);
}
Label::~Label()

3
Libraries/LibGUI/ListView.cpp
View file

@ -38,9 +38,6 @@ ListView::ListView(Widget* parent)
{
set_background_role(ColorRole::Base);
set_foreground_role(ColorRole::BaseText);
set_frame_shape(Gfx::FrameShape::Container);
set_frame_shadow(Gfx::FrameShadow::Sunken);
set_frame_thickness(2);
}
ListView::~ListView()

3
Libraries/LibGUI/ProgressBar.cpp
View file

@ -35,9 +35,6 @@ namespace GUI {
ProgressBar::ProgressBar(Widget* parent)
: Frame(parent)
{
set_frame_shape(Gfx::FrameShape::Container);
set_frame_shadow(Gfx::FrameShadow::Sunken);
set_frame_thickness(2);
}
ProgressBar::~ProgressBar()

3
Libraries/LibGUI/TextEditor.cpp
View file

@ -61,9 +61,6 @@ TextEditor::TextEditor(Type type, Widget* parent)
set_background_role(ColorRole::Base);
set_foreground_role(ColorRole::BaseText);
set_document(TextDocument::create());
set_frame_shape(Gfx::FrameShape::Container);
set_frame_shadow(Gfx::FrameShadow::Sunken);
set_frame_thickness(2);
set_scrollbars_enabled(is_multi_line());
set_font(GFontDatabase::the().get_by_name("Csilla Thin"));
// FIXME: Recompute vertical scrollbar step size on font change.