RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 09:34:59 +00:00
Code Issues Activity Actions

AK: Correctly set host when parsing URL with a base file:// host

Browse source 
We were completely missing this spec step here. Also leave a FIXME for
the pre-existing implementation of this step, as this doesn't match the
spec.
This commit is contained in:
Shannon Booth 2023-09-17 13:47:29 +12:00 • committed by Andreas Kling
parent 791ad12031
commit bfdf7779ce
3 changed files with 14 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
AK/URLParser.cpp
View file

@ -1377,6 +1377,9 @@ URL URLParser::basic_parse(StringView raw_input, Optional<URL> const& base_url,
// 1. If base is non-null and base’s scheme is "file", then:
if (base_url.has_value() && base_url->m_scheme == "file") {
// 1. Set url’s host to base’s host.
url->m_host = base_url->m_host;
// FIXME: The spec does not seem to mention these steps.
url->m_paths = base_url->m_paths;
url->m_paths.remove(url->m_paths.size() - 1);