RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:47:34 +00:00
Code Issues Activity Actions

Browser+LibWeb+WebContent: Track the source of document.cookie requests

Browse source 
To implement the HttpOnly attribute, the CookieJar needs to know where a
request originated from. Namely, it needs to distinguish between HTTP /
non-HTTP (i.e. JavaScript) requests. When the HttpOnly attribute is set,
requests from JavaScript are to be blocked.
This commit is contained in:
Timothy Flynn 2021-04-13 17:30:41 -04:00 • committed by Andreas Kling
parent 7193e518d1
commit c00760c5f9
20 changed files with 54 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/Browser/CookieJar.cpp
View file

@ -33,7 +33,7 @@
namespace Browser {
String CookieJar::get_cookie(const URL& url)
String CookieJar::get_cookie(const URL& url, Web::Cookie::Source)
{
purge_expired_cookies();
@ -55,7 +55,7 @@ String CookieJar::get_cookie(const URL& url)
return builder.build();
}
void CookieJar::set_cookie(const URL& url, const String& cookie_string)
void CookieJar::set_cookie(const URL& url, const String& cookie_string, Web::Cookie::Source)
{
auto domain = canonicalize_domain(url);
if (!domain.has_value())