RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:17:34 +00:00
Code Issues Activity Actions

LibWeb: Test nested elements in InlinePaintable::hit_test()

Browse source 
Before this change we were ignoring nested paintables inside inline
paintable during hit-testing, but now we recurse into subtree.

Fixes https://github.com/SerenityOS/serenity/issues/22927
This commit is contained in:
Aliaksandr Kalenik 2024-01-25 15:06:34 +01:00 • committed by Andreas Kling
parent 1583e6ce07
commit c02820759b
4 changed files with 37 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/hit_testing/nested-inline-paintables.txt Normal file
View file

@ -0,0 +1,2 @@
lang "en" <SPAN id="name" >
<SPAN id="value" >

15
Tests/LibWeb/Text/input/hit_testing/nested-inline-paintables.html Normal file
View file

@ -0,0 +1,15 @@
<script src="../include.js"></script>
<body>
<span id="outer">
<span id="inner">
<span id="name">lang</span>
<span id="value">"en"</span>
</span>
</span>
<script type="text/javascript">
test(() => {
printElement(internals.hitTest(10, 10).node.parentNode);
printElement(internals.hitTest(50, 10).node.parentNode);
});
</script>
</body>

7
Tests/LibWeb/Text/input/include.js
View file

@ -17,6 +17,13 @@ function println(s) {
__outputElement.appendChild(document.createTextNode(s + "\n")); __outputElement.appendChild(document.createTextNode(s + "\n"));
} }
function printElement(e) {
let element_string = `<${e.nodeName} `;
if (e.id) element_string += `id="${e.id}" `;
element_string += ">";
println(element_string);
}
document.addEventListener("DOMContentLoaded", function () { document.addEventListener("DOMContentLoaded", function () {
__outputElement = document.createElement("pre"); __outputElement = document.createElement("pre");
__outputElement.setAttribute("id", "out"); __outputElement.setAttribute("id", "out");

14
Userland/Libraries/LibWeb/Painting/InlinePaintable.cpp
View file

@ -173,7 +173,19 @@ Optional<HitTestResult> InlinePaintable::hit_test(CSSPixelPoint position, HitTes
fragment.text_index_at(position.x()) }; fragment.text_index_at(position.x()) };
} }
} }
return {};
Optional<HitTestResult> hit_test_result;
for_each_child([&](Paintable const& child) {
if (child.stacking_context())
return IterationDecision::Continue;
if (auto result = child.hit_test(position, type); result.has_value()) {
hit_test_result = result;
return IterationDecision::Break;
}
return IterationDecision::Continue;
});
return hit_test_result;
} }
CSSPixelRect InlinePaintable::bounding_rect() const CSSPixelRect InlinePaintable::bounding_rect() const