RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:57:35 +00:00
Code Issues Activity Actions

AK: Add Eternal<T> and use it in various places.

Browse source 
This is useful for static locals that never need to be destroyed:

Thing& Thing::the()
{
    static Eternal<Thing> the;
    return the;
}

The object will be allocated in data segment memory and will never have
its destructor invoked.
This commit is contained in:
Andreas Kling 2019-04-03 16:50:08 +02:00
parent 528054d192
commit c02c9880b6
23 changed files with 78 additions and 81 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Servers/WindowServer/WSClipboard.cpp
View file

@ -1,11 +1,10 @@
#include <WindowServer/WSClipboard.h>
#include <AK/Eternal.h>
WSClipboard& WSClipboard::the()
{
static WSClipboard* s_the;
if (!s_the)
s_the = new WSClipboard;
return *s_the;
static Eternal<WSClipboard> the;
return the;
}
WSClipboard::WSClipboard()

4
Servers/WindowServer/WSClipboard.h
View file

@ -7,7 +7,7 @@
class WSClipboard final : public WSMessageReceiver {
public:
static WSClipboard& the();
virtual ~WSClipboard() override;
WSClipboard();
bool has_data() const
{
@ -21,7 +21,7 @@ public:
void set_data(Retained<SharedBuffer>&&, int contents_size);
private:
WSClipboard();
virtual ~WSClipboard() override;
virtual void on_message(const WSMessage&) override;
RetainPtr<SharedBuffer> m_shared_buffer;

2
Servers/WindowServer/WSWindowManager.cpp
View file

@ -473,7 +473,7 @@ void WSWindowManager::paint_window_frame(const WSWindow& window)
if (!s_close_button_bitmap)
s_close_button_bitmap = &CharacterBitmap::create_from_ascii(s_close_button_bitmap_data, s_close_button_bitmap_width, s_close_button_bitmap_height).leak_ref();
StylePainter::the().paint_button(*m_back_painter, close_button_rect, ButtonStyle::Normal, false, false);
StylePainter::paint_button(*m_back_painter, close_button_rect, ButtonStyle::Normal, false, false);
auto x_location = close_button_rect.center();
x_location.move_by(-(s_close_button_bitmap_width / 2), -(s_close_button_bitmap_height / 2));