mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 04:47:35 +00:00
Kernel: Clarify ambiguous {File,Description}::absolute_path
Found due to smelly code in InodeFile::absolute_path. In particular, this replaces the following misleading methods: File::absolute_path This method *never* returns an actual path, and if called on an InodeFile (which is impossible), it would VERIFY_NOT_REACHED(). OpenFileDescription::try_serialize_absolute_path OpenFileDescription::absolute_path These methods do not guarantee to return an actual path (just like the other method), and just like Custody::absolute_path they do not guarantee accuracy. In particular, just renaming the method made a TOCTOU bug obvious. The new method signatures use KResultOr, just like try_serialize_absolute_path() already did.
This commit is contained in:
parent
88ca12f037
commit
c05c5a7ff4
28 changed files with 83 additions and 65 deletions
|
@ -64,8 +64,8 @@ public:
|
|||
|
||||
KResultOr<NonnullOwnPtr<KBuffer>> read_entire_file();
|
||||
|
||||
KResultOr<NonnullOwnPtr<KString>> try_serialize_absolute_path();
|
||||
String absolute_path() const;
|
||||
KResultOr<NonnullOwnPtr<KString>> original_absolute_path() const;
|
||||
KResultOr<NonnullOwnPtr<KString>> pseudo_path() const;
|
||||
|
||||
bool is_direct() const { return m_direct; }
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue