RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 15:07:45 +00:00
Code Issues Activity Actions

AK/ByteBuffer+Everywhere: Handle errors in ByteBuffer::slice()

Browse source
This commit is contained in:
Matthias Zimmerman 2022-06-13 05:20:42 -07:00 • committed by Linus Groh
parent c0486f93d4
commit c10d48b72c
12 changed files with 45 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibTLS/Socket.cpp
View file

@ -27,8 +27,8 @@ ErrorOr<Bytes> TLSv12::read(Bytes bytes)
return Bytes {};
}
m_context.application_buffer.span().slice(0, size_to_read).copy_to(bytes);
m_context.application_buffer = m_context.application_buffer.slice(size_to_read, m_context.application_buffer.size() - size_to_read);
TRY(m_context.application_buffer.slice(0, size_to_read)).span().copy_to(bytes);
m_context.application_buffer = TRY(m_context.application_buffer.slice(size_to_read, m_context.application_buffer.size() - size_to_read));
return Bytes { bytes.data(), size_to_read };
}
@ -47,7 +47,8 @@ String TLSv12::read_line(size_t max_size)
return {};
String line { bit_cast<char const*>(start), offset, Chomp };
m_context.application_buffer = m_context.application_buffer.slice(offset + 1, m_context.application_buffer.size() - offset - 1);
// FIXME: Propagate errors.
m_context.application_buffer = MUST(m_context.application_buffer.slice(offset + 1, m_context.application_buffer.size() - offset - 1));
return line;
}

3
Userland/Libraries/LibTLS/TLSPacketBuilder.h
View file

@ -85,7 +85,8 @@ public:
{
auto length = m_current_length;
m_current_length = 0;
return m_packet_data.slice(0, length);
// FIXME: Propagate errors.
return MUST(m_packet_data.slice(0, length));
}
inline void set(size_t offset, u8 value)
{

3
Userland/Libraries/LibTLS/TLSv12.cpp
View file

@ -92,7 +92,8 @@ void TLSv12::consume(ReadonlyBytes record)
}
if (index) {
m_context.message_buffer = m_context.message_buffer.slice(index, m_context.message_buffer.size() - index);
// FIXME: Propagate errors.
m_context.message_buffer = MUST(m_context.message_buffer.slice(index, m_context.message_buffer.size() - index));
}
}