1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-25 18:55:08 +00:00

LibJS: Implement Reflect.{isExtensible,preventExtensions}()

This commit is contained in:
Linus Groh 2020-06-02 12:36:11 +01:00 committed by Andreas Kling
parent b958e4f573
commit c1248a7fd8
3 changed files with 62 additions and 8 deletions

View file

@ -211,12 +211,12 @@ Value ReflectObject::has(Interpreter& interpreter)
return Value(target->has_property(property_key)); return Value(target->has_property(property_key));
} }
Value ReflectObject::is_extensible(Interpreter&) Value ReflectObject::is_extensible(Interpreter& interpreter)
{ {
// FIXME: For this to be useful we need one of these: auto* target = get_target_object_from(interpreter, "isExtensible");
// Object.seal(), Object.freeze(), Reflect.preventExtensions() if (!target)
// For now we just return true, as that's always the case. return {};
return Value(true); return Value(target->is_extensible());
} }
Value ReflectObject::own_keys(Interpreter& interpreter) Value ReflectObject::own_keys(Interpreter& interpreter)
@ -227,10 +227,12 @@ Value ReflectObject::own_keys(Interpreter& interpreter)
return target->get_own_properties(*target, GetOwnPropertyMode::Key); return target->get_own_properties(*target, GetOwnPropertyMode::Key);
} }
Value ReflectObject::prevent_extensions(Interpreter&) Value ReflectObject::prevent_extensions(Interpreter& interpreter)
{ {
// FIXME: Implement me :^) auto* target = get_target_object_from(interpreter, "preventExtensions");
ASSERT_NOT_REACHED(); if (!target)
return {};
return Value(target->prevent_extensions());
} }
Value ReflectObject::set(Interpreter& interpreter) Value ReflectObject::set(Interpreter& interpreter)

View file

@ -0,0 +1,29 @@
load("test-common.js");
try {
assert(Reflect.isExtensible.length === 1);
[null, undefined, "foo", 123, NaN, Infinity].forEach(value => {
assertThrowsError(() => {
Reflect.isExtensible(value);
}, {
error: TypeError,
message: "First argument of Reflect.isExtensible() must be an object"
});
});
assert(Reflect.isExtensible({}) === true);
var o = {};
o.foo = "foo";
assert(o.foo === "foo");
assert(Reflect.isExtensible(o) === true);
Reflect.preventExtensions(o);
o.bar = "bar";
assert(o.bar === undefined);
assert(Reflect.isExtensible(o) === false);
console.log("PASS");
} catch (e) {
console.log("FAIL: " + e);
}

View file

@ -0,0 +1,23 @@
load("test-common.js");
try {
assert(Reflect.preventExtensions.length === 1);
[null, undefined, "foo", 123, NaN, Infinity].forEach(value => {
assertThrowsError(() => {
Reflect.preventExtensions(value);
}, {
error: TypeError,
message: "First argument of Reflect.preventExtensions() must be an object"
});
});
var o = {};
assert(Reflect.isExtensible(o) === true);
assert(Reflect.preventExtensions(o) === true);
assert(Reflect.isExtensible(o) === false);
console.log("PASS");
} catch (e) {
console.log("FAIL: " + e);
}