RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:47:35 +00:00
Code Issues Activity Actions

LibGUI: Remove public getter Button::is_mimic_pressed()

Browse source 
This method shouldn't be used outside the class and having a getter for
a bool seems a bit overkill.
This commit is contained in:
Lucas CHOLLET 2023-01-17 17:15:25 -05:00 • committed by Andreas Kling
parent 56ceb6a106
commit c15a7b79ef
2 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGUI/Button.cpp
View file

@ -57,7 +57,7 @@ void Button::paint_event(PaintEvent& event)
Painter painter(*this); Painter painter(*this);
painter.add_clip_rect(event.rect()); painter.add_clip_rect(event.rect());
bool paint_pressed = is_being_pressed() || is_mimic_pressed() || (m_menu && m_menu->is_visible()); bool paint_pressed = is_being_pressed() || m_mimic_pressed || (m_menu && m_menu->is_visible());
Gfx::StylePainter::paint_button(painter, rect(), palette(), m_button_style, paint_pressed, is_hovered(), is_checked(), is_enabled(), is_focused(), is_default() && !another_button_has_focus()); Gfx::StylePainter::paint_button(painter, rect(), palette(), m_button_style, paint_pressed, is_hovered(), is_checked(), is_enabled(), is_focused(), is_default() && !another_button_has_focus());
@ -260,7 +260,7 @@ void Button::set_mimic_pressed(bool mimic_pressed)
void Button::timer_event(Core::TimerEvent&) void Button::timer_event(Core::TimerEvent&)
{ {
if (is_mimic_pressed()) { if (m_mimic_pressed) {
m_mimic_pressed = false; m_mimic_pressed = false;
update(); update();

1
Userland/Libraries/LibGUI/Button.h
View file

@ -64,7 +64,6 @@ public:
bool another_button_has_focus() const { return m_another_button_has_focus; } bool another_button_has_focus() const { return m_another_button_has_focus; }
void set_mimic_pressed(bool mimic_pressed); void set_mimic_pressed(bool mimic_pressed);
bool is_mimic_pressed() const { return m_mimic_pressed; };
virtual Optional<UISize> calculated_min_size() const override; virtual Optional<UISize> calculated_min_size() const override;