RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 11:57:35 +00:00
Code Issues Activity Actions

AK/Hex: Cleanup implementation

Browse source 
Problem:
- Post-increment of loop index.
- `const` variables are not marked `const`.
- Incorrect type for loop index.

Solution:
- Pre-increment loop index.
- Mark all possible variables `const`.
- Corret type for loop index.
This commit is contained in:
Lenny Maiorani 2021-04-18 11:12:03 -06:00 • committed by Andreas Kling
parent d462a56163
commit c1971df4c7
3 changed files with 50 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

4
AK/Complex.h
View file

@ -316,11 +316,11 @@ static constexpr bool approx_eq(const Complex<T>& a, const Complex<U>& b, const
return x.magnitude() <= margin; return x.magnitude() <= margin;
} }
//complex version of exp() // complex version of exp()
template<AK::Concepts::Arithmetic T> template<AK::Concepts::Arithmetic T>
static constexpr Complex<T> cexp(const Complex<T>& a) static constexpr Complex<T> cexp(const Complex<T>& a)
{ {
//FIXME: this can probably be faster and not use so many expensive trigonometric functions // FIXME: this can probably be faster and not use so many expensive trigonometric functions
if constexpr (sizeof(T) <= sizeof(float)) { if constexpr (sizeof(T) <= sizeof(float)) {
return expf(a.real()) * Complex<T>(cosf(a.imag()), sinf(a.imag())); return expf(a.real()) * Complex<T>(cosf(a.imag()), sinf(a.imag()));
} else if constexpr (sizeof(T) <= sizeof(double)) { } else if constexpr (sizeof(T) <= sizeof(double)) {

8
AK/Hex.cpp
View file

@ -42,12 +42,12 @@ Optional<ByteBuffer> decode_hex(const StringView& input)
auto output = ByteBuffer::create_zeroed(input.length() / 2); auto output = ByteBuffer::create_zeroed(input.length() / 2);
for (long unsigned int i = 0; i < input.length() / 2; i++) { for (size_t i = 0; i < input.length() / 2; ++i) {
auto c1 = decode_hex_digit(input[i * 2]); const auto c1 = decode_hex_digit(input[i * 2]);
if (c1 >= 16) if (c1 >= 16)
return {}; return {};
auto c2 = decode_hex_digit(input[i * 2 + 1]); const auto c2 = decode_hex_digit(input[i * 2 + 1]);
if (c2 >= 16) if (c2 >= 16)
return {}; return {};
@ -57,7 +57,7 @@ Optional<ByteBuffer> decode_hex(const StringView& input)
return output; return output;
} }
String encode_hex(ReadonlyBytes input) String encode_hex(const ReadonlyBytes input)
{ {
StringBuilder output(input.size() * 2); StringBuilder output(input.size() * 2);