RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:07:35 +00:00
Code Issues Activity Actions

LibWeb: Not dispatching page_did_click_link event breaks page refresh

Browse source 
The WebView url wouldn't update so reload in Tab would still use the
previous URL before any left click navigation.

I am unsure if there was any good reason not to dispatch the event when
there are no modifiers.
This commit is contained in:
Rob Ryan 2022-04-03 14:13:05 +10:00 • committed by Andreas Kling
parent 0b5adfef8c
commit c1b311835b
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Page/EventHandler.cpp
View file

@ -218,7 +218,7 @@ bool EventHandler::handle_mouseup(Gfx::IntPoint const& position, unsigned button
document->run_javascript(href.substring_view(11, href.length() - 11)); document->run_javascript(href.substring_view(11, href.length() - 11));
} else if (!url.fragment().is_null() && url.equals(document->url(), AK::URL::ExcludeFragment::Yes)) { } else if (!url.fragment().is_null() && url.equals(document->url(), AK::URL::ExcludeFragment::Yes)) {
m_browsing_context.scroll_to_anchor(url.fragment()); m_browsing_context.scroll_to_anchor(url.fragment());
} else if (modifiers != 0) { } else {
if (m_browsing_context.is_top_level()) { if (m_browsing_context.is_top_level()) {
if (auto* page = m_browsing_context.page()) if (auto* page = m_browsing_context.page())
page->client().page_did_click_link(url, link->target(), modifiers); page->client().page_did_click_link(url, link->target(), modifiers);