RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:27:35 +00:00
Code Issues Activity Actions

Kernel: Don't hold thread list lock while invoking ~Thread()

Browse source 
There is no need for this, and it can cause deadlocks if ~Thread()
ends up doing something else that requires a lock (e.g ~Process())
This commit is contained in:
Andreas Kling 2021-08-16 01:54:34 +02:00
parent 29a58459ab
commit c1c12497b5
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Kernel/Thread.cpp
View file

@ -39,13 +39,16 @@ SpinLockProtectedValue<Thread::GlobalList>& Thread::all_threads()
bool Thread::unref() const bool Thread::unref() const
{ {
return all_threads().with([&](auto&) { bool did_hit_zero = all_threads().with([&](auto&) {
if (deref_base()) if (deref_base())
return false; return false;
m_global_thread_list_node.remove(); m_global_thread_list_node.remove();
delete this;
return true; return true;
}); });
if (did_hit_zero)
delete this;
return did_hit_zero;
} }
KResultOr<NonnullRefPtr<Thread>> Thread::try_create(NonnullRefPtr<Process> process) KResultOr<NonnullRefPtr<Thread>> Thread::try_create(NonnullRefPtr<Process> process)