RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:07:46 +00:00
Code Issues Activity Actions

LibRegex: Fix assertion when parsing '(?'

Browse source 
Found by oss-fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=28186&q=label%3AProj-serenity
This commit is contained in:
AnotherTest 2020-12-03 12:28:47 +03:30 • committed by Andreas Kling
parent 4fe987ba00
commit c1c5225b72
2 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibRegex/RegexLexer.cpp
View file

@ -64,6 +64,9 @@ ALWAYS_INLINE char Lexer::peek(size_t offset) const
void Lexer::back(size_t offset) void Lexer::back(size_t offset)
{ {
if (offset == m_position + 1)
offset = m_position; // 'position == 0' occurs twice.
ASSERT(offset <= m_position); ASSERT(offset <= m_position);
if (!offset) if (!offset)
return; return;

1
Libraries/LibRegex/Tests/Regex.cpp
View file

@ -496,6 +496,7 @@ TEST_CASE(ECMA262_parse)
{ ",/=-:" }, // #4243 { ",/=-:" }, // #4243
{ "\\x" }, // Even invalid escapes are allowed if ~unicode. { "\\x" }, // Even invalid escapes are allowed if ~unicode.
{ "\\", regex::Error::InvalidTrailingEscape }, { "\\", regex::Error::InvalidTrailingEscape },
{ "(?", regex::Error::InvalidCaptureGroup },
}; };
for (auto& test : tests) { for (auto& test : tests) {