RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:17:45 +00:00
Code Issues Activity Actions

LibWeb: Make window.inner{Width,Height} return *viewport* size

Browse source 
These were incorrectly returning the content width and height of the
initial containing block. Also added spec links and comments.
This commit is contained in:
Andreas Kling 2022-02-06 01:12:57 +01:00
parent 0608de8c12
commit c1c5444c14
1 changed files with 12 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibWeb/DOM/Window.cpp
View file

@ -256,18 +256,24 @@ JS::Object* Window::create_wrapper(JS::GlobalObject& global_object)
return &global_object;
}
// https://www.w3.org/TR/cssom-view-1/#dom-window-innerwidth
int Window::inner_width() const
{
if (!associated_document().layout_node())
return 0;
return associated_document().layout_node()->content_width();
// The innerWidth attribute must return the viewport width including the size of a rendered scroll bar (if any),
// or zero if there is no viewport.
if (auto const* browsing_context = associated_document().browsing_context())
return browsing_context->viewport_rect().width();
return 0;
}
// https://www.w3.org/TR/cssom-view-1/#dom-window-innerheight
int Window::inner_height() const
{
if (!associated_document().layout_node())
return 0;
return associated_document().layout_node()->content_height();
// The innerHeight attribute must return the viewport height including the size of a rendered scroll bar (if any),
// or zero if there is no viewport.
if (auto const* browsing_context = associated_document().browsing_context())
return browsing_context->viewport_rect().height();
return 0;
}
Page* Window::page()