RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 04:17:35 +00:00
Code Issues Activity Actions

LibJS: Align NewPromiseCapability with spec changes

Browse source 
See 874ecf9

After this refactoring, we now correctly handle non-function /
non-undefined objects being passed multiple times: instead of skipping
assignment to promiseCapability altogether and failing with a
NotAFunction error in the end; on the second time the executor closure
is called, we return GetCapabilitiesExecutorCalledMultipleTimes.

This fixes the 7 `capability-executor-called-twice.js` test262 tests.
This commit is contained in:
Daniel Bertalan 2023-06-28 23:38:45 +02:00 • committed by Linus Groh
parent 0748e755d8
commit c21255da7f
2 changed files with 40 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibJS/Runtime/PromiseCapability.h
View file

@ -17,27 +17,24 @@ class PromiseCapability final : public Cell {
JS_CELL(PromiseCapability, Cell);
public:
static NonnullGCPtr<PromiseCapability> create(VM& vm, GCPtr<Object> promise, GCPtr<FunctionObject> resolve, GCPtr<FunctionObject> reject);
static NonnullGCPtr<PromiseCapability> create(VM& vm, NonnullGCPtr<Object> promise, NonnullGCPtr<FunctionObject> resolve, NonnullGCPtr<FunctionObject> reject);
virtual ~PromiseCapability() = default;
[[nodiscard]] GCPtr<Object> promise() const { return m_promise; }
void set_promise(NonnullGCPtr<Object> promise) { m_promise = promise; }
[[nodiscard]] NonnullGCPtr<Object> promise() const { return m_promise; }
[[nodiscard]] GCPtr<FunctionObject> resolve() const { return m_resolve; }
void set_resolve(NonnullGCPtr<FunctionObject> resolve) { m_resolve = resolve; }
[[nodiscard]] NonnullGCPtr<FunctionObject> resolve() const { return m_resolve; }
[[nodiscard]] GCPtr<FunctionObject> reject() const { return m_reject; }
void set_reject(NonnullGCPtr<FunctionObject> reject) { m_reject = reject; }
[[nodiscard]] NonnullGCPtr<FunctionObject> reject() const { return m_reject; }
private:
PromiseCapability(GCPtr<Object>, GCPtr<FunctionObject>, GCPtr<FunctionObject>);
PromiseCapability(NonnullGCPtr<Object>, NonnullGCPtr<FunctionObject>, NonnullGCPtr<FunctionObject>);
virtual void visit_edges(Visitor&) override;
GCPtr<Object> m_promise;
GCPtr<FunctionObject> m_resolve;
GCPtr<FunctionObject> m_reject;
NonnullGCPtr<Object> m_promise;
NonnullGCPtr<FunctionObject> m_resolve;
NonnullGCPtr<FunctionObject> m_reject;
};
// 27.2.1.1.1 IfAbruptRejectPromise ( value, capability ), https://tc39.es/ecma262/#sec-ifabruptrejectpromise