1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:07:35 +00:00

LibWeb: Correct escape handling in CSS Tokenizer

Calling is_valid_escape_sequence() with no arguments hides what it
is operating on, so I have removed that, so that you must explicitly
tell it what you are testing.

The call from consume_a_token() was using the wrong tokens, so it
returned false incorrectly. This was resulting in corrupted output
when faced with this code from Acid2. (Abbreviated)

```css
.parser { error: \}; }
.parser { }
```
This commit is contained in:
Sam Atkins 2021-07-09 19:48:51 +01:00 committed by Andreas Kling
parent e381ca258f
commit c249fbd17c
2 changed files with 3 additions and 9 deletions

View file

@ -92,7 +92,6 @@ private:
void consume_the_remnants_of_a_bad_url();
void consume_comments();
void reconsume_current_input_code_point();
[[nodiscard]] bool is_valid_escape_sequence();
[[nodiscard]] static bool is_valid_escape_sequence(U32Twin);
[[nodiscard]] bool would_start_an_identifier();
[[nodiscard]] bool would_start_an_identifier(U32Triplet);