From c2655d37334583d5a1b449b463011ec9dd00d8a4 Mon Sep 17 00:00:00 2001 From: Yedaya Katsman Date: Tue, 20 Dec 2022 21:24:42 +0200 Subject: [PATCH] LibSQL: Output a more specific error on failed socket creation This can fail if /run/user/$pid/ doesn't exist, which can happen on wsl without systemd. --- Userland/Libraries/LibSQL/SQLClient.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibSQL/SQLClient.cpp b/Userland/Libraries/LibSQL/SQLClient.cpp index ae37d47498..611c6736bc 100644 --- a/Userland/Libraries/LibSQL/SQLClient.cpp +++ b/Userland/Libraries/LibSQL/SQLClient.cpp @@ -52,7 +52,12 @@ static ErrorOr create_database_socket(DeprecatedString const& socket_path) static ErrorOr launch_server(DeprecatedString const& socket_path, DeprecatedString const& pid_path, StringView server_path) { - auto server_fd = TRY(create_database_socket(socket_path)); + auto server_fd_or_error = create_database_socket(socket_path); + if (server_fd_or_error.is_error()) { + warnln("Failed to create a database socket at {}: {}", socket_path, server_fd_or_error.error()); + return server_fd_or_error.release_error(); + } + auto server_fd = server_fd_or_error.value(); auto server_pid = TRY(Core::System::fork()); if (server_pid == 0) {