RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 14:47:46 +00:00
Code Issues Activity Actions

AK: Give DisjointChunks::m_chunks an inline capacity of 1

Browse source 
That's one fewer level of indirection for flattened ones.
This commit is contained in:
Ali Mohammad Pur 2022-11-16 01:22:34 +03:30 • committed by Ali Mohammad Pur
parent e9b9527440
commit c2b20b5681
1 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

17
AK/DisjointChunks.h
View file

@ -15,11 +15,11 @@
namespace AK { namespace AK {
template<typename ChunkType, bool IsConst> template<typename ChunkType, bool IsConst, size_t InlineCapacity = 0>
struct DisjointIterator { struct DisjointIterator {
struct EndTag { struct EndTag {
}; };
using ReferenceType = Conditional<IsConst, AddConst<Vector<ChunkType>>, Vector<ChunkType>>&; using ReferenceType = Conditional<IsConst, AddConst<Vector<ChunkType, InlineCapacity>>, Vector<ChunkType, InlineCapacity>>&;
DisjointIterator(ReferenceType chunks) DisjointIterator(ReferenceType chunks)
: m_chunks(chunks) : m_chunks(chunks)
@ -232,6 +232,9 @@ FixedArray<T> shatter_chunk(FixedArray<T>& source_chunk, size_t start, size_t sl
template<typename T, typename ChunkType = Vector<T>> template<typename T, typename ChunkType = Vector<T>>
class DisjointChunks { class DisjointChunks {
private:
constexpr static auto InlineCapacity = IsCopyConstructible<ChunkType> ? 1 : 0;
public: public:
DisjointChunks() = default; DisjointChunks() = default;
~DisjointChunks() = default; ~DisjointChunks() = default;
@ -397,10 +400,10 @@ public:
m_chunks.remove(1, m_chunks.size() - 1); m_chunks.remove(1, m_chunks.size() - 1);
} }
DisjointIterator<ChunkType, false> begin() { return { m_chunks }; } DisjointIterator<ChunkType, false, InlineCapacity> begin() { return { m_chunks }; }
DisjointIterator<ChunkType, false> end() { return { m_chunks, {} }; } DisjointIterator<ChunkType, false, InlineCapacity> end() { return { m_chunks, {} }; }
DisjointIterator<ChunkType, true> begin() const { return { m_chunks }; } DisjointIterator<ChunkType, true, InlineCapacity> begin() const { return { m_chunks }; }
DisjointIterator<ChunkType, true> end() const { return { m_chunks, {} }; } DisjointIterator<ChunkType, true, InlineCapacity> end() const { return { m_chunks, {} }; }
private: private:
struct ChunkAndOffset { struct ChunkAndOffset {
@ -428,7 +431,7 @@ private:
return { &m_chunks.last(), index - (offset - m_chunks.last().size()) }; return { &m_chunks.last(), index - (offset - m_chunks.last().size()) };
} }
Vector<ChunkType> m_chunks; Vector<ChunkType, InlineCapacity> m_chunks;
}; };
} }