RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 03:57:43 +00:00
Code Issues Activity Actions

LibGfx: Fix crash during rasterizing glyphs containing only one point

Browse source 
Fixes https://github.com/SerenityOS/serenity/issues/20179
This commit is contained in:
Aliaksandr Kalenik 2023-10-17 22:12:58 +02:00 • committed by Alexander Kalenik
parent f568937133
commit c2eaa0eb1c
2 changed files with 46 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Tests/LibGfx/TestFontHandling.cpp
View file

@ -9,6 +9,7 @@
#include <LibCore/ResourceImplementationFile.h>
#include <LibGfx/Font/BitmapFont.h>
#include <LibGfx/Font/FontDatabase.h>
#include <LibGfx/Font/OpenType/Glyf.h>
#include <LibTest/TestCase.h>
#include <stdio.h>
#include <stdlib.h>
@ -172,3 +173,21 @@ TEST_CASE(test_character_set_masking)
EXPECT(!masked_font->glyph_index(0x0100).has_value());
EXPECT(masked_font->glyph_index(0xFFFD).value() == 0x1FD);
}
TEST_CASE(rasterize_glyph_containing_single_off_curve_point)
{
Vector<u8> glyph_data {
0, 5, 0, 205, 255, 51, 7, 51, 6, 225, 0, 3, 0, 6, 0, 9, 0, 12, 0, 15, 0, 31, 64, 13, 13, 2, 15, 5, 7, 2, 8, 5, 10, 3, 0,
5, 3, 0, 47, 47, 51, 17, 51, 17, 51, 17, 51, 17, 51, 17, 51, 48, 49, 19, 33, 17, 33, 1, 33, 1, 1, 17, 1, 1, 33, 9, 3,
205, 6, 102, 249, 154, 5, 184, 250, 248, 2, 133, 2, 199, 253, 125, 253, 57, 5, 4, 253, 127, 253, 53, 2, 133, 253,
123, 6, 225, 248, 82, 7, 68, 252, 231, 252, 145, 6, 50, 252, 231, 252, 149, 3, 23, 253, 57, 3, 27, 3, 29, 0, 1, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 6, 177, 2, 81, 43, 48, 49, 48, 0
};
OpenType::Glyf glyf(glyph_data.span());
auto glyph = glyf.glyph(118);
EXPECT(glyph.has_value());
EXPECT_NO_CRASH("rasterizing glyph containing single off-curve point should not crash", [&] {
(void)glyph->rasterize(0, 0, 1, 1, {}, [&](u16) -> Optional<OpenType::Glyf::Glyph> { VERIFY_NOT_REACHED(); });
return Test::Crash::Failure::DidNotCrash;
});
}