RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:28:12 +00:00
Code Issues Activity Actions

LibJS: Replace the verify in private identifier with a syntax error

Browse source 
Since sometimes expressions are parsed without checking we can hit this
expression without it being followed by an 'in'.
This commit is contained in:
davidot 2021-11-27 00:16:01 +01:00 • committed by Linus Groh
parent b7c7d54167
commit c2ebaa9d87
2 changed files with 15 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibJS/Parser.cpp
View file

@ -1439,7 +1439,8 @@ Parser::PrimaryExpressionParseResult Parser::parse_primary_expression()
goto read_as_identifier;
return { parse_await_expression() };
case TokenType::PrivateIdentifier:
VERIFY(next_token().type() == TokenType::In);
if (next_token().type() != TokenType::In)
syntax_error("Cannot have a private identifier in expression if not followed by 'in'");
if (!is_private_identifier_valid())
syntax_error(String::formatted("Reference to undeclared private field or method '{}'", m_state.current_token.value()));
return { create_ast_node<PrivateIdentifier>({ m_state.current_token.filename(), rule_start.position(), position() }, consume().value()) };
@ -3483,7 +3484,7 @@ bool Parser::match_expression() const
|| type == TokenType::TemplateLiteralStart
|| type == TokenType::NullLiteral
|| match_identifier()
|| (type == TokenType::PrivateIdentifier && next_token().type() == TokenType::In)
|| type == TokenType::PrivateIdentifier
|| type == TokenType::Await
|| type == TokenType::New
|| type == TokenType::Class