RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 14:27:35 +00:00
Code Issues Activity Actions

Kernel: Move deferred call code into separate DeferredCallPool class

Browse source 
This allows us to share this code between the x86_64 and aarch64 build.
This commit is contained in:
Timon Kruiper 2023-02-22 23:32:00 +01:00 • committed by Andrew Kaster
parent 1f68ac600c
commit c31dc82b17
7 changed files with 154 additions and 105 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Kernel/Arch/aarch64/Processor.cpp
View file

@ -91,6 +91,8 @@ void Processor::early_initialize(u32 cpu)
void Processor::initialize(u32)
{
m_deferred_call_pool.init();
dmesgln("CPU[{}]: Supports {}", m_cpu, build_cpu_feature_names(m_features));
dmesgln("CPU[{}]: Physical address bit width: {}", m_cpu, m_physical_address_bit_width);
dmesgln("CPU[{}]: Virtual address bit width: {}", m_cpu, m_virtual_address_bit_width);
@ -132,7 +134,7 @@ void Processor::do_leave_critical()
VERIFY(m_in_critical > 0);
if (m_in_critical == 1) {
if (m_in_irq == 0) {
// FIXME: Call deferred_call_execute_pending()!
m_deferred_call_pool.execute_pending();
VERIFY(m_in_critical == 1);
}
m_in_critical = 0;
@ -402,6 +404,10 @@ void Processor::exit_trap(TrapFrame& trap)
// FIXME: Figure out if we need prev_irq_level, see duplicated code in Kernel/Arch/x86/common/Processor.cpp
m_in_irq = 0;
// Process the deferred call queue. Among other things, this ensures
// that any pending thread unblocks happen before we enter the scheduler.
m_deferred_call_pool.execute_pending();
auto* current_thread = Processor::current_thread();
if (current_thread) {
auto& current_trap = current_thread->current_trap();
@ -542,4 +548,17 @@ void Processor::set_thread_specific_data(VirtualAddress thread_specific_data)
Aarch64::Asm::set_tpidr_el0(thread_specific_data.get());
}
void Processor::deferred_call_queue(Function<void()> callback)
{
// NOTE: If we are called outside of a critical section and outside
// of an irq handler, the function will be executed before we return!
ScopedCritical critical;
auto& cur_proc = Processor::current();
auto* entry = cur_proc.m_deferred_call_pool.get_free();
entry->handler_value() = move(callback);
cur_proc.m_deferred_call_pool.queue_entry(entry);
}
}

9
Kernel/Arch/aarch64/Processor.h
View file

@ -11,6 +11,8 @@
#include <AK/Function.h>
#include <AK/Types.h>
#include <Kernel/Arch/DeferredCallEntry.h>
#include <Kernel/Arch/DeferredCallPool.h>
#include <Kernel/Arch/ProcessorSpecificDataID.h>
#include <Kernel/Arch/aarch64/CPUID.h>
#include <Kernel/Arch/aarch64/Registers.h>
@ -255,10 +257,7 @@ public:
return Processor::current_id() == 0;
}
static void deferred_call_queue(Function<void()> /* callback */)
{
TODO_AARCH64();
}
static void deferred_call_queue(Function<void()>);
static u32 smp_wake_n_idle_processors(u32 wake_count);
@ -282,6 +281,8 @@ private:
void do_leave_critical();
DeferredCallPool m_deferred_call_pool {};
u32 m_cpu;
CPUFeature::Type m_features;
u8 m_physical_address_bit_width;