RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 15:37:46 +00:00
Code Issues Activity Actions

LibCore+LibConfig+ConfigServer: Add Config::{add,remove}_group()

Browse source 
Plumbs synchronous calls for adding and removing group entries to
config files. This is useful for services like SystemServer which
default to group names for executable paths, and for removing all
keys at once.
This commit is contained in:
thankyouverycool 2022-09-23 09:45:05 -04:00 • committed by Ali Mohammad Pur
parent 6f394d9ee2
commit c34f2e75e9
10 changed files with 97 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Userland/Libraries/LibConfig/Client.cpp
View file

@ -75,6 +75,16 @@ void Client::remove_key(StringView domain, StringView group, StringView key)
remove_key_entry(domain, group, key);
}
void Client::remove_group(StringView domain, StringView group)
{
remove_group_entry(domain, group);
}
void Client::add_group(StringView domain, StringView group)
{
add_group_entry(domain, group);
}
void Client::notify_changed_string_value(String const& domain, String const& group, String const& key, String const& value)
{
Listener::for_each([&](auto& listener) {
@ -103,4 +113,18 @@ void Client::notify_removed_key(String const& domain, String const& group, Strin
});
}
void Client::notify_removed_group(String const& domain, String const& group)
{
Listener::for_each([&](auto& listener) {
listener.config_group_was_removed(domain, group);
});
}
void Client::notify_added_group(String const& domain, String const& group)
{
Listener::for_each([&](auto& listener) {
listener.config_group_was_added(domain, group);
});
}
}

14
Userland/Libraries/LibConfig/Client.h
View file

@ -35,6 +35,8 @@ public:
void write_i32(StringView domain, StringView group, StringView key, i32 value);
void write_bool(StringView domain, StringView group, StringView key, bool value);
void remove_key(StringView domain, StringView group, StringView key);
void remove_group(StringView domain, StringView group);
void add_group(StringView domain, StringView group);
static Client& the();
@ -48,6 +50,8 @@ private:
void notify_changed_i32_value(String const& domain, String const& group, String const& key, i32 value) override;
void notify_changed_bool_value(String const& domain, String const& group, String const& key, bool value) override;
void notify_removed_key(String const& domain, String const& group, String const& key) override;
void notify_removed_group(String const& domain, String const& group) override;
void notify_added_group(String const& domain, String const& group) override;
};
inline Vector<String> list_groups(StringView domain)
@ -95,6 +99,16 @@ inline void remove_key(StringView domain, StringView group, StringView key)
Client::the().remove_key(domain, group, key);
}
inline void remove_group(StringView domain, StringView group)
{
Client::the().remove_group(domain, group);
}
inline void add_group(StringView domain, StringView group)
{
Client::the().add_group(domain, group);
}
inline void pledge_domains(Vector<String> const& domains)
{
Client::the().pledge_domains(domains);

8
Userland/Libraries/LibConfig/Listener.cpp
View file

@ -45,4 +45,12 @@ void Listener::config_key_was_removed(String const&, String const&, String const
{
}
void Listener::config_group_was_removed(String const&, String const&)
{
}
void Listener::config_group_was_added(String const&, String const&)
{
}
}

2
Userland/Libraries/LibConfig/Listener.h
View file

@ -20,6 +20,8 @@ public:
virtual void config_i32_did_change(String const& domain, String const& group, String const& key, i32 value);
virtual void config_bool_did_change(String const& domain, String const& group, String const& key, bool value);
virtual void config_key_was_removed(String const& domain, String const& group, String const& key);
virtual void config_group_was_removed(String const& domain, String const& group);
virtual void config_group_was_added(String const& domain, String const& group);
protected:
Listener();