RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 02:57:44 +00:00
Code Issues Activity Actions

LibJS: Implement Number.isFinite()

Browse source 
Like the global isFinite() without the number coercion.
This commit is contained in:
Linus Groh 2020-04-26 18:24:58 +01:00 • committed by Andreas Kling
parent b094c064d8
commit c350f5ae67
6 changed files with 40 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibJS/Runtime/GlobalObject.cpp
View file

@ -144,8 +144,7 @@ Value GlobalObject::is_nan(Interpreter& interpreter)
Value GlobalObject::is_finite(Interpreter& interpreter)
{
auto value = interpreter.argument(0).to_number();
return Value(!value.is_infinity() && !value.is_nan());
return Value(interpreter.argument(0).to_number().is_finite_number());
}
}

6
Libraries/LibJS/Runtime/NumberConstructor.cpp
View file

@ -40,6 +40,7 @@ namespace JS {
NumberConstructor::NumberConstructor()
: NativeFunction("Number", *interpreter().global_object().function_prototype())
{
put_native_function("isFinite", is_finite, 1);
put_native_function("isSafeInteger", is_safe_integer, 1);
put("prototype", interpreter().global_object().number_prototype());
@ -73,6 +74,11 @@ Value NumberConstructor::construct(Interpreter& interpreter)
return NumberObject::create(interpreter.global_object(), number);
}
Value NumberConstructor::is_finite(Interpreter& interpreter)
{
return Value(interpreter.argument(0).is_finite_number());
}
Value NumberConstructor::is_safe_integer(Interpreter& interpreter)
{
if (!interpreter.argument(0).is_number())

1
Libraries/LibJS/Runtime/NumberConstructor.h
View file

@ -42,6 +42,7 @@ private:
virtual bool has_constructor() const override { return true; }
virtual const char* class_name() const override { return "NumberConstructor"; }
static Value is_finite(Interpreter&);
static Value is_safe_integer(Interpreter&);
};