From c3567faa8c2ca2918ee103bb817c930c0f0b2b7c Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Tue, 5 Jul 2022 19:20:00 +0200 Subject: [PATCH] LibJS: Remove unnecessary checks for undefined before ToPositiveInteger This is an editorial change in the Temporal spec. See: https://github.com/tc39/proposal-temporal/commit/9f3bf53 --- Userland/Libraries/LibJS/Runtime/Temporal/Calendar.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/Calendar.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/Calendar.cpp index dbd0dc6c62..9ad33c2aaa 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/Calendar.cpp +++ b/Userland/Libraries/LibJS/Runtime/Temporal/Calendar.cpp @@ -227,11 +227,11 @@ ThrowCompletionOr calendar_month(GlobalObject& global_object, Object& ca // 2. Let result be ? Invoke(calendar, "month", « dateLike »). auto result = TRY(Value(&calendar).invoke(global_object, vm.names.month, &date_like)); - // 3. If result is undefined, throw a RangeError exception. + // NOTE: Explicitly handled for a better error message similar to the other calendar property AOs if (result.is_undefined()) return vm.throw_completion(global_object, ErrorType::TemporalInvalidCalendarFunctionResult, vm.names.month.as_string(), vm.names.undefined.as_string()); - // 4. Return ? ToPositiveInteger(result). + // 3. Return ? ToPositiveInteger(result). return TRY(to_positive_integer(global_object, result)); } @@ -261,11 +261,11 @@ ThrowCompletionOr calendar_day(GlobalObject& global_object, Object& cale // 2. Let result be ? Invoke(calendar, "day", « dateLike »). auto result = TRY(Value(&calendar).invoke(global_object, vm.names.day, &date_like)); - // 3. If result is undefined, throw a RangeError exception. + // NOTE: Explicitly handled for a better error message similar to the other calendar property AOs if (result.is_undefined()) return vm.throw_completion(global_object, ErrorType::TemporalInvalidCalendarFunctionResult, vm.names.day.as_string(), vm.names.undefined.as_string()); - // 4. Return ? ToPositiveInteger(result). + // 3. Return ? ToPositiveInteger(result). return TRY(to_positive_integer(global_object, result)); }