RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 16:07:45 +00:00
Code Issues Activity Actions

Libraries: Use default constructors/destructors in LibWeb

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-03-14 13:21:51 -06:00 • committed by Linus Groh
parent c0dd188c4d
commit c37820b898
237 changed files with 243 additions and 730 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -70,11 +70,6 @@ TokenStream<T>::TokenStream(Vector<T> const& tokens)
{
}
template<typename T>
TokenStream<T>::~TokenStream()
{
}
template<typename T>
bool TokenStream<T>::has_next_token()
{
@ -164,10 +159,6 @@ Parser::Parser(ParsingContext const& context, StringView input, String const& en
{
}
Parser::~Parser()
{
}
NonnullRefPtr<CSSStyleSheet> Parser::parse_as_stylesheet()
{
return parse_a_stylesheet(m_token_stream);

4
Userland/Libraries/LibWeb/CSS/Parser/Parser.h
View file

@ -59,7 +59,7 @@ template<typename T>
class TokenStream {
public:
explicit TokenStream(Vector<T> const&);
~TokenStream();
~TokenStream() = default;
TokenStream(TokenStream<T> const&) = delete;
@ -87,7 +87,7 @@ private:
class Parser {
public:
Parser(ParsingContext const&, StringView input, String const& encoding = "utf-8");
~Parser();
~Parser() = default;
// The normal parser entry point, for parsing stylesheets.
NonnullRefPtr<CSSStyleSheet> parse_as_stylesheet();

16
Userland/Libraries/LibWeb/CSS/Parser/StyleRules.cpp
View file

@ -25,16 +25,16 @@ DeclarationOrAtRule::DeclarationOrAtRule(StyleDeclarationRule declaration)
, m_declaration(move(declaration))
{
}
DeclarationOrAtRule::~DeclarationOrAtRule() { }
DeclarationOrAtRule::~DeclarationOrAtRule() = default;
StyleRule::StyleRule(StyleRule::Type type)
: m_type(type)
{
}
StyleRule::~StyleRule() { }
StyleRule::~StyleRule() = default;
StyleBlockRule::StyleBlockRule() { }
StyleBlockRule::~StyleBlockRule() { }
StyleBlockRule::StyleBlockRule() = default;
StyleBlockRule::~StyleBlockRule() = default;
StyleComponentValueRule::StyleComponentValueRule(Token token)
: m_type(StyleComponentValueRule::ComponentType::Token)
@ -51,10 +51,10 @@ StyleComponentValueRule::StyleComponentValueRule(NonnullRefPtr<StyleBlockRule> b
, m_block(block)
{
}
StyleComponentValueRule::~StyleComponentValueRule() { }
StyleComponentValueRule::~StyleComponentValueRule() = default;
StyleDeclarationRule::StyleDeclarationRule() { }
StyleDeclarationRule::~StyleDeclarationRule() { }
StyleDeclarationRule::StyleDeclarationRule() = default;
StyleDeclarationRule::~StyleDeclarationRule() = default;
StyleFunctionRule::StyleFunctionRule(String name)
: m_name(move(name))
@ -66,7 +66,7 @@ StyleFunctionRule::StyleFunctionRule(String name, Vector<StyleComponentValueRule
, m_values(move(values))
{
}
StyleFunctionRule::~StyleFunctionRule() { }
StyleFunctionRule::~StyleFunctionRule() = default;
template<class SeparatorType, class CollectionType>
void append_with_to_string(StringBuilder& builder, SeparatorType& separator, CollectionType& collection)