RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 05:47:35 +00:00
Code Issues Activity Actions

LibWeb: Restore clipping of positioned descendants

Browse source 
63c727a was meant to stop clipping absolutely positioned descendants,
but used `is_positioned()` rather than `is_absolutely_positioned()`,
which meant it disabled clipping in many more cases that it should
have.
This commit is contained in:
MacDue 2022-09-24 14:30:00 +01:00 • committed by Andreas Kling
parent 7165dbce5c
commit c3841e1667
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Painting/StackingContext.cpp
View file

@ -135,7 +135,7 @@ void StackingContext::paint_internal(PaintContext& context) const
auto paint_child = [&](auto* child) { auto paint_child = [&](auto* child) {
auto parent = child->m_box.parent(); auto parent = child->m_box.parent();
auto should_clip_overflow = child->m_box.is_positioned() ? Paintable::ShouldClipOverflow::No : Paintable::ShouldClipOverflow::Yes; auto should_clip_overflow = child->m_box.is_absolutely_positioned() ? Paintable::ShouldClipOverflow::No : Paintable::ShouldClipOverflow::Yes;
auto* paintable = parent ? parent->paintable() : nullptr; auto* paintable = parent ? parent->paintable() : nullptr;
if (paintable) if (paintable)
paintable->before_children_paint(context, PaintPhase::Foreground, should_clip_overflow); paintable->before_children_paint(context, PaintPhase::Foreground, should_clip_overflow);