RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:48:12 +00:00
Code Issues Activity Actions

Kernel: Stop using *LockRefPtr for Thread

Browse source 
These were stored in a bunch of places. The main one that's a bit iffy
is the Mutex::m_holder one, which I'm going to simplify in a subsequent
commit.

In Plan9FS and WorkQueue, we can't make the NNRPs const due to
initialization order problems. That's probably doable with further
cleanup, but left as an exercise for our future selves.

Before starting this, I expected the thread blockers to be a problem,
but as it turns out they were super straightforward (for once!) as they
don't mutate the thread after initiating a block, so they can just use
simple const-ified NNRPs.
This commit is contained in:
Andreas Kling 2023-04-02 20:40:47 +02:00
parent a098266ff5
commit c3915e4058
9 changed files with 26 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Kernel/Thread.h
View file

@ -67,10 +67,10 @@ public:
return Processor::current_thread();
}
static ErrorOr<NonnullLockRefPtr<Thread>> try_create(NonnullRefPtr<Process>);
static ErrorOr<NonnullRefPtr<Thread>> create(NonnullRefPtr<Process>);
~Thread();
static LockRefPtr<Thread> from_tid(ThreadID);
static RefPtr<Thread> from_tid(ThreadID);
static void finalize_dying_threads();
ThreadID tid() const { return m_tid; }
@ -294,7 +294,7 @@ public:
private:
BlockerSet* m_blocker_set { nullptr };
NonnullLockRefPtr<Thread> m_thread;
NonnullRefPtr<Thread> const m_thread;
u8 m_was_interrupted_by_signal { 0 };
bool m_is_blocking { false };
bool m_was_interrupted_by_death { false };
@ -429,7 +429,7 @@ public:
bool unblock(void*, bool);
private:
NonnullLockRefPtr<Thread> m_joinee;
NonnullRefPtr<Thread> const m_joinee;
void*& m_joinee_exit_value;
ErrorOr<void>& m_try_join_result;
bool m_did_unblock { false };
@ -961,7 +961,7 @@ public:
return !m_is_joinable;
}
ErrorOr<NonnullLockRefPtr<Thread>> try_clone(Process&);
ErrorOr<NonnullRefPtr<Thread>> clone(NonnullRefPtr<Process>);
template<IteratorFunction<Thread&> Callback>
static IterationDecision for_each_in_state(State, Callback);